Skip to content

make sure that Python dependency is actually used for VTK 9.0.1#16741

Merged
boegel merged 1 commit intoeasybuilders:developfrom
ocaisa:20221124164335_new_pr_VTK901
Nov 25, 2022
Merged

make sure that Python dependency is actually used for VTK 9.0.1#16741
boegel merged 1 commit intoeasybuilders:developfrom
ocaisa:20221124164335_new_pr_VTK901

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Nov 24, 2022 •
edited by boegel
Loading

(created using eb --new-pr)

edit (by @boegel): this fixes the following compilation error:

error: lvalue required as increment operand 154210 | ++Py_REFCNT(o);

Culprit is system Python 3.10 being used, see also https://gitlab.kitware.com/paraview/paraview/-/issues/21511 and EESSI/software-layer#204

ocaisa
ocaisa commented Nov 24, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/v/VTK/VTK-9.0.1-foss-2020b.eb
configopts += "-DOPENGL_INCLUDE_DIR=$EBROOTMESA/include "
# Python
configopts += "-DVTK_WRAP_PYTHON=ON -DVTK_PYTHON_VERSION=3 -DVTK_PYTHON_OPTIONAL_LINK=OFF "
configopts += '-DPython3_EXECUTABLE=$EBROOTPYTHON/bin/python '
Copy link
Copy Markdown
Member Author

@ocaisa ocaisa Nov 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried

configopts += "-DPython3_ROOT_DIR=$EBROOTPYTHON "

which appears in later easyconfigs for VTK, but that didn't work:

== 2022-11-24 16:49:59,340 run.py:624 INFO cmd " cmake -DCMAKE_INSTALL_PREFIX=/project/def-sponsor00/easybuild/software/VTK/9.0.1-foss-2021a -DCMAKE_BUILD_TYPE=Release -DCMAKE_SYSROOT=/cvmfs/pilot.eessi-hpc.org/versions/2021.12/compat/linux/x86_64 -DCMAKE_C_COMPILER='/project/def-sponsor00/easybuild/software/OpenMPI/4.1.1-GCC-10.3.0/bin/mpicc' -DCMAKE_C_FLAGS='-O2 -ftree-vectorize -march=native -fno-math-errno' -DCMAKE_CXX_COMPILER='/project/def-sponsor00/easybuild/software/OpenMPI/4.1.1-GCC-10.3.0/bin/mpicxx' -DCMAKE_CXX_FLAGS='-O2 -ftree-vectorize -march=native -fno-math-errno' -DCMAKE_Fortran_COMPILER='/project/def-sponsor00/easybuild/software/OpenMPI/4.1.1-GCC-10.3.0/bin/mpifort' -DCMAKE_Fortran_FLAGS='-O2 -ftree-vectorize -march=native -fno-math-errno' -DCMAKE_SKIP_RPATH=ON -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_FIND_USE_PACKAGE_REGISTRY=FALSE -DOPENGL_glu_LIBRARY=$EBROOTLIBGLU/lib/libGLU.so -DOPENGL_gl_LIBRARY=$EBROOTMESA/lib/libGL.so -DOPENGL_INCLUDE_DIR=$EBROOTMESA/include -DVTK_WRAP_PYTHON=ON -DVTK_PYTHON_VERSION=3 -DVTK_PYTHON_OPTIONAL_LINK=OFF -DPython3_ROOT_DIR=$EBROOTPYTHON -DVTK_USE_MPI=ON -DCMAKE_INSTALL_LIBDIR=lib /project/60005/easybuild/build/VTK/9.0.1/foss-2021a/VTK-9.0.1/" exited with exit code 0 and output:
-- Found Python3: /cvmfs/pilot.eessi-hpc.org/versions/2021.12/compat/linux/x86_64/usr/bin/python3.10 (found suitable version "3.10.0", minimum required is "3.2") found components: Interpreter Development.Module Development.Embed

Copy link
Copy Markdown
Member

@boegel boegel Nov 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should also try and check whether the -DPython3_ROOT_DIR is really correct, also when a newer system Python version is available too

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Nov 24, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 24, 2022

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=16741 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16741 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9665

Test results coming soon (I hope)...

Details

- notification for comment with ID 1326678805 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 24, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/cafd583b3db7fb25ad85a3ad01659875 for a full test report.

@hmeiland hmeiland mentioned this pull request Nov 25, 2022
Closed
@boegel boegel added bug fix EESSI Related to EESSI project labels Nov 25, 2022
@boegel boegel changed the title Make sure VTK finds the specified Python make sure that Python dependency is actually used for VTK 9.0.1 Nov 25, 2022
@boegel boegel added this to the next release (4.7.0) milestone Nov 25, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 25, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3102.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/374ca15e43cd41edc32a0f3adcdd2b58 for a full test report.

boegel
boegel approved these changes Nov 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 25, 2022

Going in, thanks @ocaisa!

@boegel boegel merged commit 0248e8a into easybuilders:develop Nov 25, 2022
@boegel boegel mentioned this pull request Jan 2, 2023
Merged
@boegel boegel mentioned this pull request Oct 2, 2023
Merged
@boegel boegel mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ocaisa @boegelbot @boegel