Skip to content

use geo moduleclass for SimPEG 0.14.1#16847

Merged
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
branfosj:simpeg
Dec 11, 2022
Merged

use geo moduleclass for SimPEG 0.14.1#16847
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
branfosj:simpeg

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Dec 11, 2022 •
edited
Loading

Noticed this while looking at #16837 and #16836

@branfosj branfosj added this to the next release (4.7.0) milestone Dec 11, 2022
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Dec 11, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 11, 2022

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=16847 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16847 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9738

Test results coming soon (I hope)...

Details

- notification for comment with ID 1345508633 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 11, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/8d09f31e71971626e34055f90e41ce8f for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Dec 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Dec 11, 2022

Going in, thanks @branfosj!

@SebastianAchilles SebastianAchilles merged commit fa44150 into easybuilders:develop Dec 11, 2022
@branfosj branfosj deleted the simpeg branch December 11, 2022 10:57
@boegel boegel changed the title geo moduleclass for SimPEG consistently use geo moduleclass for SimPEG Dec 12, 2022
@boegel boegel changed the title consistently use geo moduleclass for SimPEG use geo moduleclass for SimPEG 0.14.1 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegelbot @SebastianAchilles