Skip to content

{tools}[GCC/11.2.0] mstore v0.2.0#16892

Merged
smoors merged 1 commit intoeasybuilders:developfrom
sassy-crick:20221214161935_new_pr_mstore020
Dec 27, 2022
Merged

{tools}[GCC/11.2.0] mstore v0.2.0#16892
smoors merged 1 commit intoeasybuilders:developfrom
sassy-crick:20221214161935_new_pr_mstore020

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Dec 14, 2022

(created using eb --new-pr)

@sassy-crick sassy-crick mentioned this pull request Dec 14, 2022
Closed
3 tasks
@SebastianAchilles SebastianAchilles added this to the 4.x milestone Dec 14, 2022
@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Dec 14, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 14, 2022

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=16892 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16892 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9779

Test results coming soon (I hope)...

Details

- notification for comment with ID 1351745008 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 14, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/bd2337a64109cf75375d9b082b82fe5c for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 27, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 27, 2022

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16892 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_16892 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1973

Test results coming soon (I hope)...

Details

- notification for comment with ID 1365795896 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 27, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/9558982d36674756da17fd264397ef67 for a full test report.

@smoors smoors modified the milestones: 4.x, next release (4.7.0) Dec 27, 2022
smoors
smoors approved these changes Dec 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 27, 2022

Going in, thanks @sassy-crick!

@smoors smoors merged commit 6d555ca into easybuilders:develop Dec 27, 2022
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 27, 2022

@sassy-crick I was a bit too fast in merging this.
would you mind creating a follow-up PR for this with a sanity_check_command added?

sanity_check_commands = ['mstore-fortranize --help']

@sassy-crick sassy-crick deleted the 20221214161935_new_pr_mstore020 branch December 28, 2022 15:48
sassy-crick pushed a commit to sassy-crick/easybuild-easyconfigs that referenced this pull request Dec 28, 2022
Addition to PR easybuilders#16892 : Sanity check command added
aac0907
@sassy-crick
Copy link
Copy Markdown
Collaborator Author

sassy-crick commented Dec 28, 2022

Done (PR #17029) and assigned to you.

@sassy-crick sassy-crick restored the 20221214161935_new_pr_mstore020 branch March 29, 2023 17:18
@sassy-crick sassy-crick deleted the 20221214161935_new_pr_mstore020 branch March 29, 2023 17:18
@sassy-crick sassy-crick mentioned this pull request Mar 29, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sassy-crick @SebastianAchilles @boegelbot @smoors