Skip to content

fix installation of Bowtie2 v2.4.4+ on non-x86_64 systems#16946

Merged
boegel merged 2 commits intoeasybuilders:developfrom
sib-swiss:20221219150248_new_pr_Bowtie2244
Dec 21, 2022
Merged

fix installation of Bowtie2 v2.4.4+ on non-x86_64 systems#16946
boegel merged 2 commits intoeasybuilders:developfrom
sib-swiss:20221219150248_new_pr_Bowtie2244

Conversation

@SIB-software
Copy link
Copy Markdown
Contributor

@SIB-software SIB-software commented Dec 19, 2022

(created using eb --new-pr)

@smoretti smoretti added bug fix EESSI Related to EESSI project aarch64 Related to Arm 64-bit (aarch64) labels Dec 19, 2022
smoors
smoors previously requested changes Dec 20, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/b/Bowtie2/Bowtie2-2.4.4-GCC-10.3.0.eb Outdated
Comment thread easybuild/easyconfigs/b/Bowtie2/Bowtie2-2.4.4-GCC-11.2.0.eb Outdated
@boegel boegel added this to the 4.x milestone Dec 20, 2022
@boegel boegel changed the title Bowtie2 2.4.4+ fix for non-x86_64 systems fix installation of Bowtie2 v2.4.4+ on non-x86_64 systems Dec 20, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 21, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3104.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/17dfe70f45e65761fc680a0c204dd0c3 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 21, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
fair-mastodon-c6g-2xlarge-0001 - Linux Rocky Linux 8.5, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/1a4d55b40d6446142e16fb5f45eabcb0 for a full test report.

boegel
boegel approved these changes Dec 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 21, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 21, 2022

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16946 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16946 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9855

Test results coming soon (I hope)...

Details

- notification for comment with ID 1360964352 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 21, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/34302fa61afb8954e174365238a60ef0 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 21, 2022

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
easybuild2.novalocal - Linux CentOS Stream 8, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/00d38dae93b15279d452d9c5e4616601 for a full test report.

@boegel boegel dismissed smoors’s stale review December 21, 2022 07:56

requested changes made

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 21, 2022

Going in, thanks @SIB-software!

@boegel boegel merged commit b1a0a38 into easybuilders:develop Dec 21, 2022
@smoretti smoretti mentioned this pull request Dec 22, 2022
Closed
@smoretti smoretti deleted the 20221219150248_new_pr_Bowtie2244 branch December 22, 2022 13:56
@boegel boegel modified the milestones: 4.x, next release (4.7.0) Jan 2, 2023
@bedroge bedroge mentioned this pull request Nov 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors left review comments

@boegel boegel boegel approved these changes

+1 more reviewer

@smoretti smoretti smoretti left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

aarch64 Related to Arm 64-bit (aarch64) bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@SIB-software @boegel @boegelbot @smoretti @smoors