Skip to content

add pkgconf dependency for ICU and add patch to avoid trouble with long path names for nodejs-16.15.1/GCCcore-11.3.0#16990

Merged
smoors merged 2 commits intoeasybuilders:developfrom
crubb:20221221225253_new_pr_nodejs16151
Dec 22, 2022
Merged

add pkgconf dependency for ICU and add patch to avoid trouble with long path names for nodejs-16.15.1/GCCcore-11.3.0#16990
smoors merged 2 commits intoeasybuilders:developfrom
crubb:20221221225253_new_pr_nodejs16151

Conversation

@crubb
Copy link
Copy Markdown
Contributor

@crubb crubb commented Dec 21, 2022

(created using eb --new-pr)

@crubb
Add pkg-config dependency for icu and adapt old argument-list-too…
2d2879e 
…-long.patch (long pathnames may break building `nodejs`)
@crubb crubb changed the title Add pkg-config dependency for icu and adapt old argument-list-too-long.patch (long pathnames may break building nodejs) nodejs-16.15.1/GCCcore-11.3.0: Add pkg-config dependency for icu and adapt old argument-list-too-long.patch (long pathnames may break building nodejs) Dec 21, 2022
smoors
smoors reviewed Dec 22, 2022
View reviewed changes
Comment thread easybuild/easyconfigs/n/nodejs/nodejs-16.15.1-GCCcore-11.3.0.eb Outdated

builddependencies = [
('binutils', '2.38'),
('pkg-config', '0.29.2'),
Copy link
Copy Markdown
Contributor

@smoors smoors Dec 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg-config is no longer maintained, so from 2022a onward we prefer to use pkgconf where possible

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 22, 2022

@boegelbot: please test @ generoso

@smoors smoors added the bug fix label Dec 22, 2022
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 22, 2022

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=16990 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16990 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9876

Test results coming soon (I hope)...

Details

- notification for comment with ID 1362598402 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 22, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/d62bba74f81f0909b94ad1153db162d1 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 22, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 22, 2022

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16990 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_16990 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1952

Test results coming soon (I hope)...

Details

- notification for comment with ID 1362762416 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel changed the title nodejs-16.15.1/GCCcore-11.3.0: Add pkg-config dependency for icu and adapt old argument-list-too-long.patch (long pathnames may break building nodejs) add pkg-config dependency for ICU and add patch to avoid trouble with long path names for nodejs-16.15.1/GCCcore-11.3.0 Dec 22, 2022
@boegel boegel changed the title add pkg-config dependency for ICU and add patch to avoid trouble with long path names for nodejs-16.15.1/GCCcore-11.3.0 add pkgconf dependency for ICU and add patch to avoid trouble with long path names for nodejs-16.15.1/GCCcore-11.3.0 Dec 22, 2022
@boegel boegel added this to the next release (4.7.0) milestone Dec 22, 2022
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 22, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/3a1e9b9ae63cc808aecd4a102ee7f7d7 for a full test report.

smoors
smoors approved these changes Dec 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 22, 2022

Going in, thanks @crubb!

@smoors smoors merged commit 7a1570d into easybuilders:develop Dec 22, 2022
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 22, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3136.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/98d336c12b677ca7ca270940fce1bcf6 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@crubb @smoors @boegelbot @boegel