Skip to content

add missing pkgconf build dependency to Transformers v4.24.0#17020

Merged
smoors merged 2 commits intoeasybuilders:developfrom
crubb:20221227125232_new_pr_Transformers4240
Dec 28, 2022
Merged

add missing pkgconf build dependency to Transformers v4.24.0#17020
smoors merged 2 commits intoeasybuilders:developfrom
crubb:20221227125232_new_pr_Transformers4240

Conversation

@crubb
Copy link
Copy Markdown
Contributor

@crubb crubb commented Dec 27, 2022

(created using eb --new-pr)

@crubb crubb changed the title {math}[foss/2022a] Transformers v4.24.0 - Add missing \pkgconf\ build dependency {math}[foss/2022a] Transformers v4.24.0 - Add missing pkgconf build dependency Dec 27, 2022
@smoors smoors added the bug fix label Dec 28, 2022
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 28, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 28, 2022

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=17020 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17020 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9900

Test results coming soon (I hope)...

Details

- notification for comment with ID 1366490438 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 28, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/7352c04d97e0412c1a06d6338c7a0ff4 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 28, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 28, 2022

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17020 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17020 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1982

Test results coming soon (I hope)...

Details

- notification for comment with ID 1366507763 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 28, 2022

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/1a810dc498b48955a7fb38bfebf9a04c for a full test report.

smoors
smoors approved these changes Dec 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the next release (4.7.0) milestone Dec 28, 2022
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 28, 2022

Going in, thanks @crubb!

@smoors smoors merged commit 3b692db into easybuilders:develop Dec 28, 2022
@boegel boegel changed the title {math}[foss/2022a] Transformers v4.24.0 - Add missing pkgconf build dependency add missing pkgconf build dependency to Transformers v4.24.0 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@crubb @smoors @boegelbot