Skip to content

add alternative checksum for UCX 1.13.1 after source tarball was changed in-place (without actual code changes)#17077

Merged
boegel merged 4 commits intoeasybuilders:developfrom
branfosj:20230111125039_new_pr_UCX1131
Jan 12, 2023
Merged

add alternative checksum for UCX 1.13.1 after source tarball was changed in-place (without actual code changes)#17077
boegel merged 4 commits intoeasybuilders:developfrom
branfosj:20230111125039_new_pr_UCX1131

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jan 11, 2023 •
edited
Loading

(created using eb --new-pr)

fixes #17075

https://github.com/openucx/ucx/releases/tag/v1.13.1 shows as being from 2nd January.

$ ls -l
-rw-rw-r--  1 branfosj gITS_BEAR_2017-branfosj-rse 2999570 Jan 11 12:45 ucx-1.13.1-new.tar.gz
-rwx------  1 branfosj gITS_BEAR_2017-branfosj-rse 2979566 Jan 11 12:46 ucx-1.13.1-old.tar.gz

Running a diff on the unpacked sources shows no changes.

$ sha256sum ucx-1.13.1-*.tar.gz
2c4a2f96c700e3705e185c2846a710691b6e800e8aec11fd4b3e47bcc3990548  ucx-1.13.1-new.tar.gz
efc37829b68e131d2acc82a3fd4334bfd611156a756837ffeb650ab9a9dd3828  ucx-1.13.1-old.tar.gz

@branfosj branfosj added this to the next release (4.7.1?) milestone Jan 11, 2023
@branfosj branfosj mentioned this pull request Jan 11, 2023
Closed
@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Jan 11, 2023 •
edited by boegel
Loading

I'll file an issue as well for UCX (edit: see openucx/ucx#8810)

@boegelbot

This comment was marked as outdated.

Sign in to view
@bartoldeman bartoldeman mentioned this pull request Jan 11, 2023
Open
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jan 11, 2023

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u36b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/34f074049222b340b21f9ef4c592895b for a full test report.

boegel
boegel previously approved these changes Jan 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Alternative checksum for UCX 1.13.1 add alternative checksum for UCX 1.13.1 after source tarball was changed in-place (without actual code changes) Jan 11, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 11, 2023

@boegelbot please test @ generoso
EB_ARGS="--force-download --sourcepath /tmp/boegelbot/pr17077 --installpath /tmp/boegelbot/pr17077"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 11, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17077 EB_ARGS="--force-download --sourcepath /tmp/boegelbot/pr17077 --installpath /tmp/boegelbot/pr17077" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17077 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9959

Test results coming soon (I hope)...

Details

- notification for comment with ID 1378933914 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 11, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/c6220579403737b04c87e568fbf7a484 for a full test report.

@rfj82982
Copy link
Copy Markdown

rfj82982 commented Jan 11, 2023

I think the same patch needs to be applied also to the CUDA version UCX-CUDA-1.13.1-GCCcore-12.2.0-CUDA-12.0.0.eb. I had the same problem while trying to install CUDA 12 and NCCL `NCCL-2.16.2-GCCcore-12.2.0-CUDA-12.0.0.eb

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jan 11, 2023

I think the same patch needs to be applied also to the CUDA version UCX-CUDA-1.13.1-GCCcore-12.2.0-CUDA-12.0.0.eb. I had the same problem while trying to install CUDA 12 and NCCL `NCCL-2.16.2-GCCcore-12.2.0-CUDA-12.0.0.eb

Thanks. Yes, I missed that when created the PR.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 11, 2023

@boegelbot please test @ generoso
EB_ARGS="--force-download --sourcepath /tmp/boegelbot/pr17077 --installpath /tmp/boegelbot/pr17077"

boegel
boegel approved these changes Jan 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 11, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17077 EB_ARGS="--force-download --sourcepath /tmp/boegelbot/pr17077 --installpath /tmp/boegelbot/pr17077" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17077 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9961

Test results coming soon (I hope)...

Details

- notification for comment with ID 1379065538 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 11, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/9847732e86b0f9c7fc345e80aa648276 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 12, 2023

Going in, thanks @branfosj!

@boegel boegel merged commit 13a2754 into easybuilders:develop Jan 12, 2023
@branfosj branfosj deleted the 20230111125039_new_pr_UCX1131 branch January 12, 2023 13:10
@boegel boegel mentioned this pull request Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

Checksum for UCX 1.13.1 has changed

5 participants

@branfosj @bartoldeman @boegelbot @boegel @rfj82982