Skip to content

{devel}[system/system] FCM v2021.05.0#17115

Merged
akesandgren merged 5 commits intoeasybuilders:developfrom
sassy-crick:20230116115139_new_pr_FCM2021050
May 12, 2025
Merged

{devel}[system/system] FCM v2021.05.0#17115
akesandgren merged 5 commits intoeasybuilders:developfrom
sassy-crick:20230116115139_new_pr_FCM2021050

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

@sassy-crick sassy-crick commented Jan 16, 2023

(created using eb --new-pr)

@zao
Copy link
Copy Markdown
Contributor

zao commented Feb 18, 2023

Test report by @zao
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
eb-rocky9.zao.se - Linux Rocky Linux 9.1 (Blue Onyx), x86_64, AMD Ryzen 9 3900X 12-Core Processor, Python 3.9.14
See https://gist.github.com/10bbfc7ae09d198a49d6a85d739364c3 for a full test report.

@zao
Copy link
Copy Markdown
Contributor

zao commented Feb 18, 2023

This requires an indeterminate number of additional Perl packages from the system Perl, I had to add Digest::SHA, Text::Balanced, Time::Piece, filetest, Time::HiRes on top of whatever I happened to have before on Rocky 9.

akesandgren
akesandgren requested changes May 9, 2025
View reviewed changes
Comment thread easybuild/easyconfigs/f/FCM/FCM-2021.05.0.eb Outdated

toolchain = SYSTEM

osdependencies = [('perl')] # required to run the program
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use EB Perl from SYSTEM level instead for instance the newest 5.38.0 or so

@github-actions github-actions Bot added new and removed update labels May 12, 2025
@sassy-crick
Copy link
Copy Markdown
Collaborator Author

sassy-crick commented May 12, 2025

Test report by @sassy-crick
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
hp - Linux Debian GNU/Linux 12, x86_64, 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz, Python 3.11.2
See https://gist.github.com/sassy-crick/1b1f532d316c6854427994a3c6219ed7 for a full test report.

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

sassy-crick commented May 12, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 12, 2025

@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=17115 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_17115 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6335

Test results coming soon (I hope)...

Details

- notification for comment with ID 2873273301 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 12, 2025

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/ec3a6fb7a203ebc2e80ab06f6982272b for a full test report.

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

sassy-crick commented May 12, 2025

I am not sure I understand the error from the bot:

$ ml  Perl/5.38.0
$ find $EBROOTPERL -iname SHA.pm
/home/sassy/apps/software/Perl/5.38.0/lib/perl5/5.38.0/x86_64-linux-thread-multi/Digest/SHA.pm

What am I missing?

akesandgren
akesandgren requested changes May 12, 2025
View reviewed changes
Comment thread easybuild/easyconfigs/f/FCM/FCM-2021.05.0.eb Outdated

osdependencies = [('perl')] # required to run the program
builddependencies = [
('Perl', '5.38.0', '', SYSTEM),
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since toolchain is SYSTEM you only need ('Perl', '5.38.0')

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, Perl is a dependency, not a builddependency!

akesandgren
akesandgren requested changes May 12, 2025
View reviewed changes
Comment thread easybuild/easyconfigs/f/FCM/FCM-2021.05.0.eb Outdated

osdependencies = [('perl')] # required to run the program
builddependencies = [
('Perl', '5.38.0', '', SYSTEM),
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, Perl is a dependency, not a builddependency!

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

sassy-crick commented May 12, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 12, 2025

@sassy-crick: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=17115 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_17115 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6336

Test results coming soon (I hope)...

Details

- notification for comment with ID 2873606518 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 12, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/00f7eb84004d951849aa3f2eda179933 for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented May 12, 2025

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-cn1611.hpc2n.umu.se - Linux Ubuntu 22.04, x86_64, AMD EPYC 7313 16-Core Processor, 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.58.02, Python 3.10.12
See https://gist.github.com/akesandgren/9249010fc0f7a22af0c1649ac9667f22 for a full test report.

@akesandgren akesandgren added this to the 5.0.1 milestone May 12, 2025
akesandgren
akesandgren approved these changes May 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented May 12, 2025

Going in, thanks @sassy-crick!

@akesandgren akesandgren merged commit 4d7842a into easybuilders:develop May 12, 2025
8 checks passed
@sassy-crick sassy-crick deleted the 20230116115139_new_pr_FCM2021050 branch May 12, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sassy-crick @zao @boegelbot @akesandgren