Skip to content

remove dependency on Pillow from scikit-bio v0.5.7#17178

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
lexming:20230123144710_new_pr_scikit-bio057
Jan 26, 2023
Merged

remove dependency on Pillow from scikit-bio v0.5.7#17178
jfgrimm merged 1 commit intoeasybuilders:developfrom
lexming:20230123144710_new_pr_scikit-bio057

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Jan 23, 2023 •
edited
Loading

(created using eb --new-pr)

scikit-bio does not import any module of PIL

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jan 23, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 23, 2023

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=17178 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17178 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10044

Test results coming soon (I hope)...

Details

- notification for comment with ID 1400385262 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 23, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/33673edb7fe315ea7242e04a572eff5b for a full test report.

@jfgrimm jfgrimm added this to the next release (4.7.1?) milestone Jan 26, 2023
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jan 26, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 26, 2023

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17178 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17178 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2105

Test results coming soon (I hope)...

Details

- notification for comment with ID 1405018328 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 26, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/76da2555c0ce2a0b1f86f41ef634a254 for a full test report.

jfgrimm
jfgrimm approved these changes Jan 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jan 26, 2023

Going in, thanks @lexming!

@jfgrimm jfgrimm merged commit 26a0392 into easybuilders:develop Jan 26, 2023
@lexming lexming deleted the 20230123144710_new_pr_scikit-bio057 branch January 26, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @boegelbot @jfgrimm