Skip to content

correctly specify path to libfabric installation prefix in PMIx 4.1.0 easyconfig#17204

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
akesandgren:20230125141919_new_pr_PMIx410
Jan 26, 2023
Merged

correctly specify path to libfabric installation prefix in PMIx 4.1.0 easyconfig#17204
jfgrimm merged 1 commit intoeasybuilders:developfrom
akesandgren:20230125141919_new_pr_PMIx410

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Jan 25, 2023 •
edited
Loading

(created using eb --new-pr)

The typo had no effect in practice since PMIx picks up on libfabric through CPATH/LD_LIBRARY_PATH anyway.
So this is just a cosmetic fix.

@akesandgren akesandgren added this to the 4.x milestone Jan 25, 2023
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jan 26, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 26, 2023

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=17204 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17204 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10057

Test results coming soon (I hope)...

Details

- notification for comment with ID 1404884881 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 26, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e9bc37427343ad5aae25a2bab7657906 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jan 26, 2023

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
himem06.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/9b589de1cd601b43c112536bd9da117b for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jan 26, 2023

@boegelbot please test @ jsc-zen2

@jfgrimm jfgrimm modified the milestones: 4.x, next release (4.7.1?) Jan 26, 2023
jfgrimm
jfgrimm approved these changes Jan 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 26, 2023

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17204 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17204 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2104

Test results coming soon (I hope)...

Details

- notification for comment with ID 1405017004 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 26, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/056c4b676d3c64790246f302ac560213 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jan 26, 2023

Going in, thanks @akesandgren!

@jfgrimm jfgrimm merged commit 9a3b3b4 into easybuilders:develop Jan 26, 2023
@akesandgren akesandgren deleted the 20230125141919_new_pr_PMIx410 branch January 27, 2023 07:01
@boegel boegel changed the title fix typo in PMIx-4.1.0 for EBROOTLIBFABRIC correctly specify path to libfabric installation prefix in PMIx 4.1.0 easyconfig Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@akesandgren @jfgrimm @boegelbot