Skip to content

remove duplicate SlamDunk easyconfig using lowercase name#17301

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
Micket:20230210183550_new_pr_UYrRahTpqL
Feb 11, 2023
Merged

remove duplicate SlamDunk easyconfig using lowercase name#17301
branfosj merged 1 commit intoeasybuilders:developfrom
Micket:20230210183550_new_pr_UYrRahTpqL

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Feb 10, 2023

(created using eb --new-pr)

There was already SlamDunk for the same toolchain and version, with seemingly more features. This shouldn't have been merged (and we really should introduce things to detect this with the unit tests)

fixes #17300

@Micket Micket added the bug fix label Feb 10, 2023
@branfosj branfosj added this to the next release (4.7.1?) milestone Feb 10, 2023
@branfosj
Copy link
Copy Markdown
Member

See also #11824 about the general issue of name duplication

@jhein32
Copy link
Copy Markdown
Collaborator

jhein32 commented Feb 11, 2023

Thanks to @Micket and @branfosj for reacting swiftly. Could this please be merged into "develop" as soon as possible. As things stand, the issue breaks my work repository and I see not easy way to recover. I can currently not work on easyconfigs.

Best wishes
Joachim

@branfosj branfosj merged commit 1c3caf1 into easybuilders:develop Feb 11, 2023
@jhein32
Copy link
Copy Markdown
Collaborator

jhein32 commented Feb 11, 2023

Thanks. After updating my github repository is working again.

I learned a few things (and lost some time) in the process.

@boegel boegel changed the title Remove duplicate slamdunk in lowercase remove duplicate SlamDunk easyconfig using lowercase name Feb 15, 2023
@boegel boegel added the change label Feb 15, 2023
@Micket Micket deleted the 20230210183550_new_pr_UYrRahTpqL branch April 21, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

slamdunk-0.4.3-foss-2021b.eb and SlamDunk-0.4.3-foss-2021b.eb

4 participants