Skip to content

Add case-insensitive name clash test#17303

Merged
lexming merged 15 commits intoeasybuilders:developfrom
branfosj:clash
Feb 21, 2023
Merged

Add case-insensitive name clash test#17303
lexming merged 15 commits intoeasybuilders:developfrom
branfosj:clash

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Feb 11, 2023

See #11824

======================================================================
FAIL: test_easyconfig_name_clashes (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure there is not a name clash when all names are lowercase
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 953, in test_easyconfig_name_clashes
    self.assertTrue(False, "EasyConfigs with case-insensitive name clash: %s" % duplicates)
AssertionError: False is not true : EasyConfigs with case-insensitive name clash: {'arb': ['ARB', 'Arb'], 'nanofilt': ['NanoFilt', 'nanofilt'], 'ncl': ['NCL', 'ncl'], 'check': ['Check', 'check'], 'charmm': ['charmm', 'CHARMM'], 'graphviz': ['Graphviz', 'graphviz'], 'magma': ['MAGMA', 'magma'], 'libpsml': ['libpsml', 'libPSML'], 'bamm': ['BAMM', 'BamM'], 'blasr': ['BLASR', 'blasr']}

@branfosj branfosj marked this pull request as draft February 11, 2023 14:17
@branfosj branfosj marked this pull request as ready for review February 11, 2023 15:18
Comment thread test/easyconfigs/easyconfigs.py Outdated
@verdurin verdurin changed the title Add case-insenitive name clash test Add case-insensitive name clash test Feb 13, 2023
@boegel boegel added the tests label Feb 15, 2023
@easybuilders easybuilders deleted a comment from boegelbot Feb 18, 2023
@boegelbot

This comment was marked as resolved.

Comment thread test/easyconfigs/easyconfigs.py Outdated
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Feb 21, 2023

Going in, thanks @branfosj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants