Skip to content

add ffnvcodec build dependency to all recent FFmpeg easyconfigs#17316

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Micket:20230214100053_new_pr_FFmpeg432
Feb 15, 2023
Merged

add ffnvcodec build dependency to all recent FFmpeg easyconfigs#17316
boegel merged 1 commit intoeasybuilders:developfrom
Micket:20230214100053_new_pr_FFmpeg432

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Feb 14, 2023 •
edited
Loading

(created using eb --new-pr)
Since it worked well for FFmpeg 5.0.1 i added it to all the recent older versions. Seems to work well.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Feb 14, 2023

Test report by @Micket
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
vera-c2 - Linux Rocky Linux 8.6, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/b8225277fecd585c16eb8631a00ebbe1 for a full test report.

@Micket Micket added this to the next release (4.7.1?) milestone Feb 14, 2023
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Feb 14, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 14, 2023

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=17316 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17316 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10226

Test results coming soon (I hope)...

Details

- notification for comment with ID 1429473721 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 14, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/24c1fa8217c9df8f2d39bb158e3a549b for a full test report.

@boegel boegel changed the title Add ffnvcodec support to all recent FFmpegs add ffnvcodec build dependency to all recent FFmpeg easyconfigs Feb 15, 2023
boegel
boegel approved these changes Feb 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 15, 2023

Going in, thanks @Micket!

@boegel boegel merged commit 4051a19 into easybuilders:develop Feb 15, 2023
@Micket Micket deleted the 20230214100053_new_pr_FFmpeg432 branch April 21, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @boegelbot @boegel