Skip to content

Archive ARB and blasr patch files#17346

Merged
Micket merged 2 commits intoeasybuilders:developfrom
branfosj:arb
Feb 15, 2023
Merged

Archive ARB and blasr patch files#17346
Micket merged 2 commits intoeasybuilders:developfrom
branfosj:arb

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Feb 15, 2023 •
edited
Loading

for #11824

for ARB and blasr there are only .patch files in the directory, so we'll move these into __archive__ to remove the case-insensitive directory name collision.

@branfosj branfosj added this to the next release (4.7.1?) milestone Feb 15, 2023
@branfosj branfosj changed the title Archive ARB patch files Archive ARB and blasr patch files Feb 15, 2023
Micket
Micket reviewed Feb 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think blasr patch actually belongs to __archive__/b/BLASR/ but this patch is so old it's hard to even find the software. In fact, BLASR itself has basically been removed from the internet as far as i can tell, so i could be wrong here.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 15, 2023

I think blasr patch actually belongs to __archive__/b/BLASR/ but this patch is so old it's hard to even find the software. In fact, BLASR itself has basically been removed from the internet as far as i can tell, so i could be wrong here.

It is used in https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/__archive__/b/blasr/blasr-smrtanalysis-2.1-goolf-1.4.10.eb, so I moved it into that same directory. That should have been named BLASR, but I am not sure we should bother fixing the name of an archived easyconfig.

Micket
Micket approved these changes Feb 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 4d2c433 into easybuilders:develop Feb 15, 2023
@branfosj branfosj deleted the arb branch February 15, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

2 participants

@branfosj @Micket