Skip to content

consistently use NanoFilt capitalisation#17349

Merged
Micket merged 2 commits intoeasybuilders:developfrom
branfosj:nanofilt
Feb 16, 2023
Merged

consistently use NanoFilt capitalisation#17349
Micket merged 2 commits intoeasybuilders:developfrom
branfosj:nanofilt

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Feb 15, 2023

NanoFilt capitalisation looks right to me.

for #11824

@branfosj branfosj added this to the next release (4.7.1?) milestone Feb 15, 2023
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 15, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 15, 2023

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=17349 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17349 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10246

Test results coming soon (I hope)...

Details

- notification for comment with ID 1431833172 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Micket
Micket approved these changes Feb 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 15, 2023

Do we care to test build these? toolchains are older than what i have in my test tree so i don't wanna

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 16, 2023

Do we care to test build these? toolchains are older than what i have in my test tree so i don't wanna

I've set a build off and will see how it goes. The starting point is "0 out of 72 easyconfigs done", so not as bad as I feared. However, we'll have to see if I can build all the dependencies in these older toolchains.

@verdurin verdurin changed the title consistently use NanoFilt capitailisation consistently use NanoFilt capitalisation Feb 16, 2023
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Feb 16, 2023

Test report by @verdurin
FAILED
Build succeeded for 8 out of 16 (4 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/a6b58379e5bf80410d2d46afec1ddbaa for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 16, 2023

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/471c61356c50b39b2e238faac1a6830d for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 16, 2023

Good enough for me!

@Micket Micket merged commit 85c2bec into easybuilders:develop Feb 16, 2023
@branfosj branfosj deleted the nanofilt branch February 16, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@branfosj @boegelbot @Micket @verdurin