{bio}[dummy-dummy] cramtools 2.0 (Review) by mmterpstra · Pull Request #1741 · easybuilders/easybuild-easyconfigs

mmterpstra · 2015-06-24T14:25:23Z

No description provided.

hpcugentbot · 2015-06-24T14:25:25Z

Automatic reply from Jenkins: Can I test this?

npklein · 2015-06-24T14:43:51Z

Test report by @npklein
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz, Python 2.7.9
See https://gist.github.com/d1ef08abb17f963f2e34 for a full test report.

Ignore this, fails because I can't run test on the same cluster because of group right

boegel · 2015-06-24T14:57:13Z

Jenkins: ok to test

boegel · 2015-06-24T14:57:35Z

remove this?

mmterpstra · 2015-06-24T15:00:49Z

Test report by @mmterpstra
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz, Python 2.7.9
See https://gist.github.com/91530db0522f374159ac for a full test report.

hpcugentbot · 2015-06-24T15:08:26Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3639/
Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3639/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-06-24T15:24:26Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3642/
Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3642/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-06-24T15:33:06Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3643/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3643/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

mmterpstra · 2015-06-25T08:21:02Z

Should I retest? It Should work & is now nicely formatted (i think).
Ps. 'bedankt' for commenting on branch and taking effort to add this.

mmterpstra · 2015-07-01T11:29:45Z

Test report by @mmterpstra
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz, Python 2.7.9
See https://gist.github.com/ab8b122d398239d6aa15 for a full test report.

boegel · 2015-07-01T11:39:42Z

please avoid using tabs

indent with 4 spaces instead

boegel · 2015-07-01T11:41:39Z

@mmterpstra: just a couple more minor style remarks to look into, looks great otherwise

- replaced tabs - removed hard coding in 'modloadmsg' - 'modloadmsg' now declared with single qoutes

mmterpstra · 2015-07-01T12:27:27Z

Test report by @mmterpstra
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2660 0 @ 2.20GHz, Python 2.7.9
See https://gist.github.com/4271cd07066108efc79c for a full test report.

hpcugentbot · 2015-07-01T12:35:48Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3685/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3685/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-07-01T14:07:48Z

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/61eeee729b3619baff66 for a full test report.

boegel · 2015-07-01T14:13:08Z

Going in, thanks @mmterpstra!

And welcome to the wonderful world of EasyBuild. :-)

{bio}[dummy-dummy] cramtools 2.0 (Review)

created cramtools-v2.0-Java-1.7.0_80.eb

e8350ce

mmterpstra changed the title ~~{bio}[dummy-dummy] cramtools 2.0 (Revie)~~ {bio}[dummy-dummy] cramtools 2.0 (Review) Jun 24, 2015

boegel reviewed Jun 24, 2015
View reviewed changes

Comment thread easybuild/easyconfigs/c/cramtools/cramtools-v2.0-Java-1.7.0_80.eb Outdated

Copy link
Copy Markdown

Member

boegel Jun 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this?

mmterpstra added 2 commits June 24, 2015 17:14

Update cramtools-v2.0-Java-1.7.0_80.eb

dc88b53

Rename cramtools-v2.0-Java-1.7.0_80.eb to cramtools-2.0-Java-1.7.0_80.eb

a0c410c

boegel reviewed Jul 1, 2015
View reviewed changes

boegel added this to the v2.2 milestone Jul 1, 2015

Update cramtools-2.0-Java-1.7.0_80.eb

e42a618

- replaced tabs - removed hard coding in 'modloadmsg' - 'modloadmsg' now declared with single qoutes

boegel added a commit that referenced this pull request Jul 1, 2015

Merge pull request #1741 from mmterpstra/cramtools-2.0

826d33d

{bio}[dummy-dummy] cramtools 2.0 (Review)

boegel merged commit 826d33d into easybuilders:develop Jul 1, 2015

Conversation

mmterpstra commented Jun 24, 2015

Uh oh!

hpcugentbot commented Jun 24, 2015

Uh oh!

npklein commented Jun 24, 2015

Uh oh!

boegel commented Jun 24, 2015

Uh oh!

boegel Jun 24, 2015

Choose a reason for hiding this comment

Uh oh!

mmterpstra commented Jun 24, 2015

Uh oh!

hpcugentbot commented Jun 24, 2015

Uh oh!

hpcugentbot commented Jun 24, 2015

Uh oh!

hpcugentbot commented Jun 24, 2015

Uh oh!

mmterpstra commented Jun 25, 2015

Uh oh!

mmterpstra commented Jul 1, 2015

Uh oh!

boegel Jul 1, 2015

Choose a reason for hiding this comment

Uh oh!

boegel Jul 1, 2015

Choose a reason for hiding this comment

Uh oh!

boegel commented Jul 1, 2015

Uh oh!

mmterpstra commented Jul 1, 2015

Uh oh!

hpcugentbot commented Jul 1, 2015

Uh oh!

boegel commented Jul 1, 2015

Uh oh!

boegel commented Jul 1, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants