add patch for Qt5 5.12.2 with GCCcore/11.2.0 to fix template bug by terjekv · Pull Request #17464 · easybuilders/easybuild-easyconfigs

terjekv · 2023-03-03T13:51:21Z

(created using eb --new-pr)

Micket

lgtm

SebastianAchilles

I think the patch in this PR and the patch https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/q/Qt5/Qt5-5.15.2_fix-qtwebengine-breakpad-glibc-2.34.patch are fixing the same issues. However the later one was only added to the easyconfig Qt5-5.15.5-GCCcore-11.3.0.eb (https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/q/Qt5/Qt5-5.15.5-GCCcore-11.3.0.eb#L24) but not to Qt5-5.15.2-GCCcore-11.2.0.eb.
In case Qt5-5.15.2_fix-qtwebengine-breakpad-glibc-2.34.patch works for Qt5-5.15.2-GCCcore-11.2.0.eb as well, I would prefer to use this patch here as well.

Micket · 2023-03-05T12:49:55Z

I did work.

I see another patch as well which also fixes the same type of issue, but despite it being named Qt5-5.15.2 it's actually for 5.15.5, and we annoyingly need to backport the patch.. which i'm now not sure what to call, ugh

terjekv · 2023-03-05T14:12:11Z

Gah, I looked for the same fix, and didn't find the one solving it slightly differently. Grrr. We should stick with the one already there, for sure. Sorry. :(

Micket · 2023-03-05T14:20:02Z

If "backported" the other patch as well (as far as i can tell, that patch should also be necessary?) I can push those changes to this PR if you want

terjekv · 2023-03-05T14:42:59Z

That works for me, thanks!

SebastianAchilles · 2023-03-06T09:55:34Z

I am seeing this:

Can't determine patch level for patch /tmp/eb-39sevvhn/files_pr17464/q/Qt5/Qt5-5.15.2b_fix-qtwebengine-abs
eil-cpp-glibc-2.34.patch from directory /dev/shm/easybuilder/Qt5/5.15.2/GCCcore-11.2.0/qt-everywhere-src-5.15.2

I will adjust the path in the patch.

SebastianAchilles · 2023-03-06T10:12:24Z

I will trigger test reports on three systems:

generoso / jsc-zen2: they are using an older glibc version 2.28 and did not run into the issue before,
Ubuntu 22.10 VM: this is using a newer glibc 2.36 and did run into the issue. Failing test report from before can be found here: https://gist.github.com/SebastianAchilles/81efd41e8285b1ec8bdfc8e63b0ca3a9

SebastianAchilles · 2023-03-06T10:12:41Z

@boegelbot please test @ jsc-zen2
CORE_CNT=16
EB_ARGS="--installpath /tmp/$USER/pr17464"

boegelbot · 2023-03-06T10:17:09Z

@SebastianAchilles: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17464 EB_ARGS="--installpath /tmp/$USER/pr17464" /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17464 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 2297

Test results coming soon (I hope)...

Details

- notification for comment with ID 1455847048 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

SebastianAchilles · 2023-03-06T10:50:59Z

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
zen2-ubuntu-2210 - Linux Ubuntu 22.10 (Kinetic Kudu), x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.10.7
See https://gist.github.com/88b40e7d2338603a9a3f85b00ed4d9ac for a full test report.

boegelbot · 2023-03-06T11:29:18Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/0692ee5a0812ab71ec50e249ffedf829 for a full test report.

SebastianAchilles · 2023-03-06T11:29:50Z

@boegelbot please test @ generoso
CORE_CNT=16
EB_ARGS="--installpath /tmp/$USER/pr17464"

boegelbot · 2023-03-06T11:30:09Z

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=17464 EB_ARGS="--installpath /tmp/$USER/pr17464" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17464 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 10406

Test results coming soon (I hope)...

Details

- notification for comment with ID 1455963408 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-03-06T13:04:17Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/8aa000e37b951473f3ec0900b7793449 for a full test report.

SebastianAchilles

lgtm

SebastianAchilles · 2023-03-06T16:13:05Z

Going in, thanks @terjekv!

Fixes easybuilders#17463.

873e28d

terjekv changed the title ~~Fixes #17463.~~ Fix template bug in Qt5-5.15.2-GCCcore-11.2.0.eb. Mar 3, 2023

terjekv requested a review from SebastianAchilles March 3, 2023 19:19

Micket previously approved these changes Mar 5, 2023

View reviewed changes

Micket added the bug fix label Mar 5, 2023

Micket added this to the release after 4.7.1 milestone Mar 5, 2023

SebastianAchilles reviewed Mar 5, 2023

View reviewed changes

Use existig patches

953133e

Micket dismissed their stale review via 953133e March 5, 2023 14:50

Micket requested a review from SebastianAchilles March 5, 2023 14:52

Add patch description

8f6374b

adjust path in Qt5 qtwebengine abseil patch

0840e85

SebastianAchilles approved these changes Mar 6, 2023

View reviewed changes

SebastianAchilles merged commit 7e6e704 into easybuilders:develop Mar 6, 2023

boegel changed the title ~~Fix template bug in Qt5-5.15.2-GCCcore-11.2.0.eb.~~ add patch for Qt5 5.12.2 with GCCcore/11.2.0 to fix template bug Mar 10, 2023

boegel removed this from the release after 4.7.1 milestone Mar 15, 2023

boegel added this to the next release (4.7.1) milestone Mar 15, 2023

Conversation

terjekv commented Mar 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Micket left a comment

Choose a reason for hiding this comment

Uh oh!

SebastianAchilles left a comment

Choose a reason for hiding this comment

Uh oh!

Micket commented Mar 5, 2023

Uh oh!

terjekv commented Mar 5, 2023

Uh oh!

Micket commented Mar 5, 2023

Uh oh!

terjekv commented Mar 5, 2023

Uh oh!

SebastianAchilles commented Mar 6, 2023

Uh oh!

SebastianAchilles commented Mar 6, 2023

Uh oh!

SebastianAchilles commented Mar 6, 2023

Uh oh!

boegelbot commented Mar 6, 2023

Uh oh!

SebastianAchilles commented Mar 6, 2023

Uh oh!

boegelbot commented Mar 6, 2023

Uh oh!

SebastianAchilles commented Mar 6, 2023

Uh oh!

boegelbot commented Mar 6, 2023

Uh oh!

boegelbot commented Mar 6, 2023

Uh oh!

SebastianAchilles left a comment

Choose a reason for hiding this comment

Uh oh!

SebastianAchilles commented Mar 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

terjekv commented Mar 3, 2023 •

edited

Loading