Skip to content

{bio}[foss/2022a] vitessce-python v20230222#17472

Merged
jfgrimm merged 4 commits intoeasybuilders:developfrom
deniskristak:20230306162424_new_pr_vitessce-python20230222
Mar 10, 2023
Merged

{bio}[foss/2022a] vitessce-python v20230222#17472
jfgrimm merged 4 commits intoeasybuilders:developfrom
deniskristak:20230306162424_new_pr_vitessce-python20230222

Conversation

@deniskristak
Copy link
Copy Markdown
Contributor

@deniskristak deniskristak commented Mar 6, 2023

No description provided.

@deniskristak deniskristak mentioned this pull request Mar 6, 2023
Closed
@boegel boegel changed the title adding easyconfigs: vitessce-python-20230222-foss-2022a.eb {bio}[foss/2022a] vitessce-python v20230222 Mar 6, 2023
boegel
boegel previously requested changes Mar 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deniskristak Some code style issues to fix:

vitessce-python-20230222-foss-2022a.eb:9:121: E501 line too long (127 > 120 characters)
vitessce-python-20230222-foss-2022a.eb:50:17: E126 continuation line over-indented for hanging indent
vitessce-python-20230222-foss-2022a.eb:52:12: W299 trailing whitespace
vitessce-python-20230222-foss-2022a.eb:56:17: E126 continuation line over-indented for hanging indent
vitessce-python-20230222-foss-2022a.eb:58:12: W299 trailing whitespace
vitessce-python-20230222-foss-2022a.eb:72:13: E123 closing bracket does not match indentation of opening bracket's line

@boegel boegel added the new label Mar 6, 2023
@boegel boegel added this to the 4.x milestone Mar 6, 2023
@deniskristak
Copy link
Copy Markdown
Contributor Author

deniskristak commented Mar 6, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 6, 2023

@deniskristak: Request for testing this PR well received on login1

PR test command 'EB_PR=17472 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17472 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10407

Test results coming soon (I hope)...

Details

- notification for comment with ID 1456934790 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 6, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/25aa0f7df4ac784a7fe3d622463bb96c for a full test report.

jfgrimm
jfgrimm reviewed Mar 10, 2023
View reviewed changes
Comment thread easybuild/easyconfigs/v/vitessce-python/vitessce-python-20230222-foss-2022a.eb Outdated
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Mar 10, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 10, 2023

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17472 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17472 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2311

Test results coming soon (I hope)...

Details

- notification for comment with ID 1463745379 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 10, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/e72d8e484b772298e4b935f5a3bb8ccc for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Mar 10, 2023

Test report by @jfgrimm
SUCCESS
Build succeeded for 7 out of 7 (1 easyconfigs in total)
himem04.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6230 CPU @ 2.10GHz (cascadelake), Python 3.6.8
See https://gist.github.com/01ae362b77c7d7b953af7650075b129f for a full test report.

jfgrimm
jfgrimm approved these changes Mar 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm modified the milestones: 4.x, next release (4.7.1) Mar 10, 2023
@jfgrimm jfgrimm dismissed boegel’s stale review March 10, 2023 15:29

req. changes made

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Mar 10, 2023

Going in, thanks @deniskristak!

@jfgrimm jfgrimm merged commit 281176c into easybuilders:develop Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

@boegel boegel boegel left review comments

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@deniskristak @boegelbot @jfgrimm @boegel