Skip to content

disable Python support for OTF2 v2.2, since we're not including Python 2.x as dependency#17499

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
boegel:20230310210740_new_pr_OTF222
Mar 11, 2023
Merged

disable Python support for OTF2 v2.2, since we're not including Python 2.x as dependency#17499
jfgrimm merged 1 commit intoeasybuilders:developfrom
boegel:20230310210740_new_pr_OTF222

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 10, 2023 •
edited
Loading

(created using eb --new-pr)

This fixes the following problem when a /usr/bin/python is found on the system that is not Python 2.x:

checking for a Python interpreter with version >= 2.5... python
checking for python... /usr/bin/python
checking for python version... 3.6
checking for python platform... linux
checking for python script directory... ${prefix}/lib/python3.6/site-packages
checking for python extension module directory... ${exec_prefix}/lib64/python3.6/site-packages
configure: error: OTF2 does require a Python 2 version: 3.6

@boegel boegel added the bug fix label Mar 10, 2023
@boegel boegel added this to the next release (4.7.1) milestone Mar 10, 2023
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 10, 2023

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3135.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/0f2c2f3f7f71379405f5029b764bfd3d for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 10, 2023

@boegelbot please test @ generoso

@easybuilders easybuilders deleted a comment from boegelbot Mar 10, 2023
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 10, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17499 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17499 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10436

Test results coming soon (I hope)...

Details

- notification for comment with ID 1464382695 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 10, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/8ce2a0f2f6fdf85258eafa92383c940b for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 10, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 10, 2023

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17499 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17499 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2331

Test results coming soon (I hope)...

Details

- notification for comment with ID 1464642116 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 10, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/8045fea93e274b305ef5344906f98884 for a full test report.

jfgrimm
jfgrimm approved these changes Mar 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm merged commit a4f96e7 into easybuilders:develop Mar 11, 2023
@boegel boegel deleted the 20230310210740_new_pr_OTF222 branch March 11, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @jfgrimm