Skip to content

{lib}[GCC/11.2.0] avro-cpp v1.11.1 (Apache Avro C++)#17527

Merged
casparvl merged 7 commits intoeasybuilders:developfrom
ll4strw:apache-avro
Mar 21, 2023
Merged

{lib}[GCC/11.2.0] avro-cpp v1.11.1 (Apache Avro C++)#17527
casparvl merged 7 commits intoeasybuilders:developfrom
ll4strw:apache-avro

Conversation

@ll4strw
Copy link
Copy Markdown

@ll4strw ll4strw commented Mar 14, 2023

Added easyconfig for Apache Avro C++

casparvl
casparvl requested changes Mar 14, 2023
View reviewed changes
Comment thread easybuild/easyconfigs/a/avrocpp/avrocpp-1.11.1-GCC-11.2.0.eb Outdated
@boegel boegel added this to the 4.x milestone Mar 15, 2023
@boegel boegel added the new label Mar 15, 2023
boegel
boegel previously requested changes Mar 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @ll4strw , and welcome to the wonderful world of EasyBuild!

Some additional suggestions for changes, do let us know if you have any questions...

Comment thread easybuild/easyconfigs/a/avrocpp/avrocpp-1.11.1-GCC-11.2.0.eb Outdated
Comment thread easybuild/easyconfigs/a/avrocpp/avrocpp-1.11.1-GCC-11.2.0.eb Outdated
Comment thread easybuild/easyconfigs/a/avrocpp/avrocpp-1.11.1-GCC-11.2.0.eb Outdated
Comment thread easybuild/easyconfigs/a/avrocpp/avrocpp-1.11.1-GCC-11.2.0.eb Outdated
Comment thread easybuild/easyconfigs/a/avrocpp/avrocpp-1.11.1-GCC-11.2.0.eb Outdated
Comment thread easybuild/easyconfigs/a/avrocpp/avrocpp-1.11.1-GCC-11.2.0.eb Outdated
@ll4strw ll4strw requested a review from boegel March 16, 2023 10:24
casparvl
casparvl requested changes Mar 16, 2023
View reviewed changes
Comment thread easybuild/easyconfigs/a/avro-cpp/avro-cpp-1.11.1-GCC-11.2.0.eb
@ll4strw ll4strw requested review from boegel and casparvl and removed request for boegel and casparvl March 17, 2023 16:09
@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 21, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 21, 2023

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=17527 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17527 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10527

Test results coming soon (I hope)...

Details

- notification for comment with ID 1477171833 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 21, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 21, 2023

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17527 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17527 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2400

Test results coming soon (I hope)...

Details

- notification for comment with ID 1477179433 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 21, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/7d10711c81420b91be482d60c804acac for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 21, 2023

Test report by @casparvl
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
tcn216.local.snellius.surf.nl - Linux Rocky Linux 8.7, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/73c3cdf80df636745e20bdaa02ec71a0 for a full test report.

casparvl
casparvl approved these changes Mar 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's wait for the test on Generoso to finish, and if succesful, this PR can be merged imho

Comment thread easybuild/easyconfigs/a/avro-cpp/avro-cpp-1.11.1-GCC-11.2.0.eb
@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 21, 2023

So... the bot failed to report back, but looking at the test infrastructure, the build did complete (there was only a failure in the communication back to github, so nothing related to this PR).

1 Traceback (most recent call last):
  2   File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
  3     "__main__", mod_spec)
  4   File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
  5     exec(code, run_globals)
  6   File "/home/boegelbot/easybuild/easybuild-framework/easybuild/main.py", line 734, in <module>
  7     main()
  8   File "/home/boegelbot/easybuild/easybuild-framework/easybuild/main.py", line 724, in main
  9     hooks, do_build)
 10   File "/home/boegelbot/easybuild/easybuild-framework/easybuild/main.py", line 564, in process_eb_args
 11     test_report_msg = overall_test_report(ecs_with_res, len(paths), overall_success, success_msg, init_session_state)
 12   File "/home/boegelbot/easybuild/easybuild-framework/easybuild/tools/testing.py", line 401, in overall_test_report
 13     success)
 14   File "/home/boegelbot/easybuild/easybuild-framework/easybuild/tools/testing.py", line 311, in post_pr_test_report
 15     gist_url = upload_test_report_as_gist(test_report['full'], descr=descr, fn=fn)
 16   File "/home/boegelbot/easybuild/easybuild-framework/easybuild/tools/testing.py", line 284, in upload_test_report_as_gist
 17     gist_url = create_gist(test_report, descr=descr, fn=fn, github_user=github_user)
 18   File "/home/boegelbot/easybuild/easybuild-framework/easybuild/tools/github.py", line 595, in create_gist
 19     status, data = g.gists.post(body=body)
 20   File "/home/boegelbot/easybuild/easybuild-framework/easybuild/base/rest.py", line 139, in post
 21     return self.request(self.POST, url, json.dumps(body), headers, content_type='application/json')
 22   File "/home/boegelbot/easybuild/easybuild-framework/easybuild/base/rest.py", line 176, in request
 23     conn = self.get_connection(method, url, body, headers)
 24   File "/home/boegelbot/easybuild/easybuild-framework/easybuild/base/rest.py", line 217, in get_connection
 25     connection = self.opener.open(request)
 26   File "/usr/lib64/python3.6/urllib/request.py", line 532, in open
 27     response = meth(req, response)
 28   File "/usr/lib64/python3.6/urllib/request.py", line 642, in http_response
 29     'http', request, response, code, msg, hdrs)
 30   File "/usr/lib64/python3.6/urllib/request.py", line 570, in error
 31     return self._call_chain(*args)
 32   File "/usr/lib64/python3.6/urllib/request.py", line 504, in _call_chain
 33     result = func(*args)
 34   File "/usr/lib64/python3.6/urllib/request.py", line 650, in http_error_default
 35     raise HTTPError(req.full_url, code, msg, hdrs, fp)
 36 urllib.error.HTTPError: HTTP Error 403: Forbidden
 37 == Temporary log file in case of crash /tmp/eb-4fv_3fe7/easybuild-vo9iu0iw.log
 38 == resolving dependencies ...
 39 == processing EasyBuild easyconfig /tmp/eb-4fv_3fe7/files_pr17527/a/avro-cpp/avro-cpp-1.11.1-GCC-11.2.0.eb
 40 == building and installing avro-cpp/1.11.1-GCC-11.2.0...
 41 == fetching files...
 42 == ... (took 1 secs)
 43 == creating build dir, resetting environment...
 44 == ... (took < 1 sec)
 45 == unpacking...
 46 == ... (took < 1 sec)
 47 == patching...
 48 == ... (took < 1 sec)
 49 == preparing...
 50 == ... (took 7 secs)
 51 == configuring...
 52 == ... (took 7 secs)
 53 == building...
 54 == ... (took 2 mins 8 secs)
 55 == testing...
 56 == ... (took < 1 sec)
 57 == installing...
 58 == ... (took 1 secs)
 59 == taking care of extensions...
 60 == ... (took < 1 sec)
 61 == restore after iterating...
 62 == ... (took < 1 sec)
 63 == postprocessing...
 64 == ... (took < 1 sec)
 65 == sanity checking...
 66 == Running pre-sanitycheck hook...
 67 Updated banned_linked_shared_libs build option: [' /lib/libcrypto.so.10', ' /lib/libssl.so.10', ' /lib64/libcrypto.so.10', ' /lib64/libssl.so.10', '/usr/lib/libcrypto.so.10', '/usr/lib/libssl.so.10', '/    usr/lib64/libcrypto.so.10', '/usr/lib64/libssl.so.10', ' /lib/libcrypto.so.1.1', ' /lib/libssl.so.1.1', ' /lib64/libcrypto.so.1.1', ' /lib64/libssl.so.1.1', '/usr/lib/libcrypto.so.1.1', '/usr/lib/libssl    .so.1.1', '/usr/lib64/libcrypto.so.1.1', '/usr/lib64/libssl.so.1.1']
 68 == ... (took 4 secs)
 69 == cleaning up...
 70 == ... (took < 1 sec)
 71 == creating module...
 72 == ... (took 3 secs)
 73 == permissions...
 74 == ... (took < 1 sec)
 75 == packaging...
 76 == ... (took < 1 sec)
 77 == COMPLETED: Installation ended successfully (took 2 mins 34 secs)
 78 == Results of the build can be found in the log file(s) /project/boegelbot/Rocky8/haswell/software/avro-cpp/1.11.1-GCC-11.2.0/easybuild/easybuild-avro-cpp-1.11.1-20230321.015801.log

Anyway, looks good to me, I'll merge this now :)

@casparvl casparvl dismissed boegel’s stale review March 21, 2023 20:39

Changes were done by author

@casparvl casparvl modified the milestones: 4.x, next release (4.7.2?) Mar 21, 2023
@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 21, 2023

Going in, thanks @ll4strw!

@casparvl casparvl merged commit dde469b into easybuilders:develop Mar 21, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 21, 2023

@boegelbot please test @ generoso
EB_ARGS="--sanity-check-only"

@boegel boegel changed the title Added easyconfig for Apache Avro C++ {lib}[GCC/11.2.0] avro-cpp v1.11.1 (Apache Avro C++) Mar 21, 2023
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 21, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17527 EB_ARGS="--sanity-check-only" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17527 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10534

Test results coming soon (I hope)...

Details

- notification for comment with ID 1478558624 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 21, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/543d6d28722e4e2f22fc6fcd44fc7900 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casparvl casparvl casparvl approved these changes

@boegel boegel Awaiting requested review from boegel

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.7.2

Development

Successfully merging this pull request may close these issues.

4 participants

@ll4strw @casparvl @boegelbot @boegel