Skip to content

use Binary easyblock for ANIcalculator to prevent RPATH sanity check failures#17536

Merged
boegel merged 1 commit intoeasybuilders:developfrom
bedroge:anicalculator_binary_easyblock
Mar 15, 2023
Merged

use Binary easyblock for ANIcalculator to prevent RPATH sanity check failures#17536
boegel merged 1 commit intoeasybuilders:developfrom
bedroge:anicalculator_binary_easyblock

Conversation

@bedroge
Copy link
Copy Markdown
Contributor

@bedroge bedroge commented Mar 15, 2023

This solves the issue that @casparvl found in #17503.

@bedroge bedroge mentioned this pull request Mar 15, 2023
Merged
3 tasks
@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented Mar 15, 2023

Test report by @bedroge
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 22.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.10.6
See https://gist.github.com/526018c612b513575eefd7b5d7358b02 for a full test report.

@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented Mar 15, 2023

@boegelbot please test @ generoso
EB_ARGS="--rpath"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 15, 2023

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=17536 EB_ARGS="--rpath" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17536 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10476

Test results coming soon (I hope)...

Details

- notification for comment with ID 1469523557 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 15, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/cf66ed71700fe7dd861f7dc41bcec6aa for a full test report.

@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented Mar 15, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 15, 2023

@bedroge: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17536 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17536 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2361

Test results coming soon (I hope)...

Details

- notification for comment with ID 1469528363 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 15, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/4a4735a95120f76c3e18296bc7493ab8 for a full test report.

@boegel boegel changed the title use Binary easyblock for ANIcalculator to prevent rpath sanity check failures use Binary easyblock for ANIcalculator to prevent RPATH sanity check failures Mar 15, 2023
@boegel boegel added this to the next release (4.7.1) milestone Mar 15, 2023
boegel
boegel approved these changes Mar 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 15, 2023

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
node3170.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/6cd6b815d472eef77271e4e26d56fdd7 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 15, 2023

Going in, thanks @bedroge!

@boegel boegel merged commit 7e9b696 into easybuilders:develop Mar 15, 2023
@bedroge bedroge deleted the anicalculator_binary_easyblock branch March 15, 2023 14:26
@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 15, 2023

Test report by @casparvl
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux Rocky Linux 8.7, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/f2c2fcb204fc4f573aa5d4ada81245c9 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@bedroge @boegelbot @boegel @casparvl