Skip to content

fix CodAn bin/* executable permissions for all users#17607

Merged
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:codan
Mar 28, 2023
Merged

fix CodAn bin/* executable permissions for all users#17607
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:codan

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Mar 28, 2023

No description provided.

boegel
boegel requested changes Mar 28, 2023
View reviewed changes
Comment thread easybuild/easyconfigs/c/CodAn/CodAn-1.2-foss-2021b.eb Outdated
install_cmd += "mkdir %(installdir)s/bin && "
install_cmd += "mv %(installdir)s/%(name)s-%(version)s/bin/* %(installdir)s/bin && "
install_cmd += "chmod u+rwx %(installdir)s/bin/* "
install_cmd += "chmod u+rwx,go+x %(installdir)s/bin/* "
Copy link
Copy Markdown
Member

@boegel boegel Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe go+rx is better, to avoid confusion?

Copy link
Copy Markdown
Collaborator Author

@hajgato hajgato Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically thats not needed.

@boegel boegel added this to the next release (4.7.2?) milestone Mar 28, 2023
@boegel boegel added the bug fix label Mar 28, 2023
boegel
boegel approved these changes Mar 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 28, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 28, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17607 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17607 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10553

Test results coming soon (I hope)...

Details

- notification for comment with ID 1487127910 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 28, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/1eb4b8cba8a10c89749cb1c19a7104d5 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 28, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 28, 2023

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17607 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17607 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2417

Test results coming soon (I hope)...

Details

- notification for comment with ID 1487189457 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 28, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/5d3f0f348beaff92ee9264d9c7f44324 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 28, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3110.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/1df133b7c08789fa9360fc7660eb4e07 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 28, 2023

Going in, thanks @hajgato!

@boegel boegel merged commit be10d7d into easybuilders:develop Mar 28, 2023
@boegel boegel changed the title Fix CodAn bin/* executable permissions for all users fix CodAn bin/* executable permissions for all users Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.2

Development

Successfully merging this pull request may close these issues.

3 participants

@hajgato @boegel @boegelbot