Skip to content

upgrade traitlets, ipywidgets, and widgetsnbextension + downgrade jupyterlab_widgets extensions in IPython v8.5.0 to fix known issues#17612

Merged
lexming merged 2 commits intoeasybuilders:developfrom
lexming:20230328152736_new_pr_IPython850
Mar 28, 2023
Merged

upgrade traitlets, ipywidgets, and widgetsnbextension + downgrade jupyterlab_widgets extensions in IPython v8.5.0 to fix known issues#17612
lexming merged 2 commits intoeasybuilders:developfrom
lexming:20230328152736_new_pr_IPython850

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Mar 28, 2023 •
edited
Loading

(created using eb --new-pr)

Two fixes for IPython v8.5.0:

@lexming lexming changed the title fix ipywidgets and jupyterlab_widgets in IPython v8.5.0 fix traitlets, ipywidgets and jupyterlab_widgets in IPython v8.5.0 Mar 28, 2023
@lexming lexming force-pushed the 20230328152736_new_pr_IPython850 branch from 4562562 to cbe2516 Compare March 28, 2023 13:48
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Mar 28, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 28, 2023

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=17612 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17612 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10551

Test results coming soon (I hope)...

Details

- notification for comment with ID 1486968643 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 28, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6a4fffdd8b863ff603217e7c824f9baf for a full test report.

@lexming lexming enabled auto-merge March 28, 2023 15:51
casparvl
casparvl approved these changes Mar 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same issue with traitlets and found you solved it here (and some more). Looks good to me!

@lexming lexming merged commit 9a7d143 into easybuilders:develop Mar 28, 2023
@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 28, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 28, 2023

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17612 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17612 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2418

Test results coming soon (I hope)...

Details

- notification for comment with ID 1487236903 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 28, 2023

Test report by @casparvl
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
tcn349.local.snellius.surf.nl - Linux Rocky Linux 8.7, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/5bf7c16be7e950609e472a0f5244f727 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 28, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/8a03630bcf3ea11d579ddaf9e6d1fc04 for a full test report.

@boegel boegel added this to the next release (4.7.2?) milestone Mar 29, 2023
@boegel boegel changed the title fix traitlets, ipywidgets and jupyterlab_widgets in IPython v8.5.0 upgrade traitlets, ipywidgets, and widgetsnbextension + downgrade jupyterlab_widgets extensions in IPython v8.5.0 to fix known issues Mar 29, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 29, 2023

@lexming Is there any way we can add a small test that's run in the sanity check to catch some of these problems?
With a standalone script for example that is run during sanity check, like we do with TensorFlow (see TensorFlow-2.x_mnist-test.py)...

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Mar 29, 2023

@boegel in this case the errors only showed up inside a JupyterLab environment, so it is not easy to reproduce with a sanity check. In the future more strict version requirements set upstream should make pip trip if we use the wrong module versions.

@lexming lexming deleted the 20230328152736_new_pr_IPython850 branch March 29, 2023 08:07
@arielzn arielzn mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casparvl casparvl casparvl approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.2

Development

Successfully merging this pull request may close these issues.

4 participants

@lexming @boegelbot @casparvl @boegel