Skip to content

add patch for GPAW-22.8.0 with 2022a toolchain to make test tolerance a bit less strict#17618

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
schiotz:20230329131142_new_pr_GPAW2280
Mar 29, 2023
Merged

add patch for GPAW-22.8.0 with 2022a toolchain to make test tolerance a bit less strict#17618
branfosj merged 1 commit intoeasybuilders:developfrom
schiotz:20230329131142_new_pr_GPAW2280

Conversation

@schiotz
Copy link
Copy Markdown
Contributor

@schiotz schiotz commented Mar 29, 2023

(created using eb --new-pr)

@schiotz schiotz changed the title Bug fix: Tolerance too tight in test suite. GPAW-22.8.0/{foss,intel}-2022a Bug fix: Tolerance too tight in test suite. Mar 29, 2023
@schiotz
Copy link
Copy Markdown
Contributor Author

schiotz commented Mar 29, 2023

An overly tight tolerance in a test in the test suite causes the self-test to fail, which is an issue in connection with some benchmarking work.

@branfosj branfosj added this to the next release (4.7.2?) milestone Mar 29, 2023
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Mar 29, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 29, 2023

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=17618 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17618 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10558

Test results coming soon (I hope)...

Details

- notification for comment with ID 1489010121 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 29, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/5b6cdad9419d399c16aad95b7d17a010 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Mar 29, 2023

Test report by @branfosj
SUCCESS
Build succeeded for 8 out of 8 (2 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/067dc79ce098e99977c27be2e3dbbfd8 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Mar 29, 2023

Going in, thanks @schiotz!

@branfosj branfosj merged commit 7d0ce57 into easybuilders:develop Mar 29, 2023
@boegel boegel changed the title GPAW-22.8.0/{foss,intel}-2022a Bug fix: Tolerance too tight in test suite. add patch for GPAW-22.8.0 with 2022a toolchain to make test tolerance a bit less strict Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.2

Development

Successfully merging this pull request may close these issues.

3 participants

@schiotz @branfosj @boegelbot