Skip to content

remove LLVM build dependency from TensorFlow easyconfigs#17641

Merged
smoors merged 1 commit intoeasybuilders:developfrom
branfosj:20230401133640_new_pr_TensorFlow271
Apr 3, 2023
Merged

remove LLVM build dependency from TensorFlow easyconfigs#17641
smoors merged 1 commit intoeasybuilders:developfrom
branfosj:20230401133640_new_pr_TensorFlow271

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Apr 1, 2023 •
edited
Loading

(created using eb --new-pr)

# for debugging with llvm-symbolizer, to be removed

Doing as it says and removing it.

@branfosj branfosj added this to the next release (4.7.2?) milestone Apr 1, 2023
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Apr 1, 2023

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 1, 2023

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=17641 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17641 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10580

Test results coming soon (I hope)...

Details

- notification for comment with ID 1492959188 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel changed the title Remove LLVM builddep from TensorFlow remove LLVM build dependency from TensorFlow easyconfigs Apr 1, 2023
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 1, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/dddf0d2c4d4c19736421c409f787c233 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 2, 2023

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (3 easyconfigs in total)
node3307.joltik.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), 1 x NVIDIA Tesla V100-SXM2-32GB, 525.85.12, Python 3.6.8
See https://gist.github.com/boegel/1246a34fc462b54487fe7adc0864b796 for a full test report.

smoors
smoors approved these changes Apr 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Apr 3, 2023

Going in, thanks @branfosj!

@smoors smoors merged commit d40721e into easybuilders:develop Apr 3, 2023
@branfosj branfosj deleted the 20230401133640_new_pr_TensorFlow271 branch April 3, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

4.7.2

Development

Successfully merging this pull request may close these issues.

4 participants

@branfosj @boegelbot @boegel @smoors