Skip to content

remove exts_filter definition from Python 3.4.3 easyconfig, as it can cause problems#1765

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:python343_exts_filter
Jul 3, 2015
Merged

remove exts_filter definition from Python 3.4.3 easyconfig, as it can cause problems#1765
boegel merged 1 commit intoeasybuilders:developfrom
boegel:python343_exts_filter

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jul 3, 2015

cfr. easybuilders/easybuild-framework#1313

It's unclear to me why this is even there, especially since this is the only Python 3.x easyconfig that has this.
@JensTimmerman: the original easyconfig is yours (see #1598), any idea why this is there?

It's not unlikely this also fixes easybuilders/easybuild-easyblocks#609.

@boegel boegel mentioned this pull request Jul 3, 2015
Closed
@JensTimmerman
Copy link
Copy Markdown

JensTimmerman commented Jul 3, 2015

this must have slipped in whilst I was testing something, my bad, ok to go in.

@boegel boegel added this to the v2.2 milestone Jul 3, 2015
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Jul 3, 2015

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3702/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3702/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 3, 2015

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/51187b4a654178c89ead for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 3, 2015

Thanks for the review @JensTimmerman!

boegel added a commit that referenced this pull request Jul 3, 2015
@boegel
Merge pull request #1765 from boegel/python343_exts_filter
9f7cdac 
remove exts_filter definition from Python 3.4.3 easyconfig, as it can cause problems
@boegel boegel merged commit 9f7cdac into easybuilders:develop Jul 3, 2015
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 3, 2015

Thanks @gppezzi for bringing this up!

@boegel boegel deleted the python343_exts_filter branch July 3, 2015 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @JensTimmerman @hpcugentbot