Skip to content

Add Clang easyconfig, along with CMake easyconfig variant.#177

Merged
boegel merged 12 commits intoeasybuilders:developfrom
gribozavr:clang
Apr 6, 2013
Merged

Add Clang easyconfig, along with CMake easyconfig variant.#177
boegel merged 12 commits intoeasybuilders:developfrom
gribozavr:clang

Conversation

@gribozavr
Copy link
Copy Markdown
Contributor

Clang depends on a GCC installation for libstdc++, thus the dependency.

Clang's CMake-based build system is much nicer than autoconf-based, so we would need a CMake variant for "GCC" toolchain.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use SOURCELOWER_TAR_GZ constant here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanups done here and in other CMake easyconfigs.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 25, 2013

Nice job @gribozavr! :)

This depends on easybuilders/easybuild-easyblocks#151.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 25, 2013

OK, this looks very clean now, cool.

I'll hold off merging this until the easyblock in easybuilders/easybuild-easyblocks#151 is ready to merge...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add moduleclass = 'devel' (sorry that I missed that before, see also #159)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 'lib'?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #161, leave as-is.

Conflicts:
	easybuild/easyconfigs/i/iccifort/iccifort-2011.13.367.eb
	easybuild/easyconfigs/i/ictce/ictce-3.2.2.u3-32bit.eb
	easybuild/easyconfigs/i/ictce/ictce-3.2.2.u3.eb
	easybuild/easyconfigs/i/ictce/ictce-4.0.10.eb
	easybuild/easyconfigs/i/ictce/ictce-4.0.6.eb
	easybuild/easyconfigs/i/ictce/ictce-4.1.13.eb
	easybuild/easyconfigs/i/ictce/ictce-5.1.1.eb
	easybuild/easyconfigs/i/ictce/ictce-5.2.0.eb
	easybuild/easyconfigs/i/imkl/imkl-10.2.6.038-32bit.eb
	easybuild/easyconfigs/i/imkl/imkl-10.2.6.038.eb
	easybuild/easyconfigs/i/imkl/imkl-10.3.10.319.eb
	easybuild/easyconfigs/i/imkl/imkl-10.3.12.361-OpenMPI-1.6.3.eb
	easybuild/easyconfigs/i/imkl/imkl-10.3.12.361.eb
	easybuild/easyconfigs/i/imkl/imkl-10.3.6.233.eb
	easybuild/easyconfigs/i/imkl/imkl-11.0.1.117.eb
	easybuild/easyconfigs/i/imkl/imkl-11.0.2.146.eb
	easybuild/easyconfigs/i/impi/impi-4.0.0.028-32bit.eb
	easybuild/easyconfigs/i/impi/impi-4.0.0.028.eb
	easybuild/easyconfigs/i/impi/impi-4.0.2.003.eb
	easybuild/easyconfigs/i/impi/impi-4.1.0.027.eb
	easybuild/easyconfigs/i/impi/impi-4.1.0.030.eb
	easybuild/easyconfigs/i/iomkl/iomkl-4.6.13.eb
	easybuild/easyconfigs/i/ipp/ipp-7.0.5.233.eb
	easybuild/easyconfigs/i/itac/itac-8.0.0.011.eb
@gribozavr
Copy link
Copy Markdown
Contributor Author

Is this the correct preferred style to format hashes (see sanity_check_paths commit)?

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 3, 2013

@gribozavr:

4-space indent is better:

sanity_check_paths = {
    'files': ['bin/clang', 'bin/clang++', 'lib/libclang.so', 'lib/clang/3.2/include/stddef.h'],
    'dirs': []
}

@gribozavr
Copy link
Copy Markdown
Contributor Author

@boegel Fixed.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 6, 2013

@gribozavr: You noted that the broken tests with -DGCC_INSTALL_PREFIX being used (by the Clang easyblock, see easybuilders/easybuild-easyblocks#151) also indicate that crosscompilation is broken when GCC is in a non-standard installation prefix.

That should be followed up, right, e.g. by opening a bug on the Clang side, to get that fixed?

I think for now it's OK, as long as we're aware of crosscompilation being broken with this easyconfig, so please make a note of that in the easyconfig file, just above the patches for example (maybe point to a Clang bug report if there's one already).

@gribozavr
Copy link
Copy Markdown
Contributor Author

@gribozavr
Copy link
Copy Markdown
Contributor Author

@boegel Added a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants