Skip to content

fix building Python bindings of DGL, requires static libs#17764

Merged
Micket merged 1 commit intoeasybuilders:developfrom
akesandgren:20230420155713_new_pr_DGL091
Apr 21, 2023
Merged

fix building Python bindings of DGL, requires static libs#17764
Micket merged 1 commit intoeasybuilders:developfrom
akesandgren:20230420155713_new_pr_DGL091

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Apr 20, 2023

(created using eb --new-pr)

@akesandgren akesandgren modified the milestones: 4.x, next release (4.7.2) Apr 20, 2023
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Apr 20, 2023

@boegelbot Please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 20, 2023

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=17764 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17764 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10688

Test results coming soon (I hope)...

Details

- notification for comment with ID 1516382673 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Micket
Micket approved these changes Apr 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 20, 2023

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis1-07 - Linux Rocky Linux 8.6, x86_64, Intel(R) Xeon(R) Gold 6244 CPU @ 3.60GHz, 1 x NVIDIA Tesla V100-SXM2-32GB, 520.61.05, Python 3.6.8
See https://gist.github.com/Micket/737527eaf72711137b4b3865e1a06b2c for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 20, 2023

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis9-03 - Linux Rocky Linux 8.6, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, 4 x NVIDIA NVIDIA A40, 520.61.05, Python 3.6.8
See https://gist.github.com/Micket/064d1eb5389a096cc4e1c4a5b9933230 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 20, 2023 •
edited by akesandgren
Loading

Test report by @boegelbot
FAILED
Build succeeded for 5 out of 6 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/b351b0008e2b44d1b117d192e9ef7f30 for a full test report.

Need an actual GPU to pass tests...

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 21, 2023

Generoso doesn't have a GPU so i'm going to ignore that last failure to build DGL

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 21, 2023

Going in, thanks @akesandgren!

@Micket Micket merged commit a3906ae into easybuilders:develop Apr 21, 2023
@akesandgren akesandgren deleted the 20230420155713_new_pr_DGL091 branch April 24, 2023 09:11
@boegel boegel changed the title correct the python building of DGL, requires static libs fix building Python bindings of DGL, requires static libs May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.7.2

Development

Successfully merging this pull request may close these issues.

3 participants

@akesandgren @boegelbot @Micket