Skip to content

update JupyterLab v3.5.0 to set $JUPYTERLAB_SETTINGS_DIR and $JUPYTERLAB_WORKSPACES_DIR on loading of module#17982

Merged
verdurin merged 3 commits intoeasybuilders:developfrom
lexming:20230526120100_new_pr_JupyterLab350
Jun 22, 2023
Merged

update JupyterLab v3.5.0 to set $JUPYTERLAB_SETTINGS_DIR and $JUPYTERLAB_WORKSPACES_DIR on loading of module#17982
verdurin merged 3 commits intoeasybuilders:developfrom
lexming:20230526120100_new_pr_JupyterLab350

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented May 26, 2023

(created using eb --new-pr)

@verdurin
Copy link
Copy Markdown
Member

verdurin commented May 26, 2023

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/e8d735ee9d7b987dafbdda6cdea20acd for a full test report.

verdurin
verdurin reviewed May 26, 2023
View reviewed changes
Comment thread easybuild/easyconfigs/j/JupyterLab/JupyterLab-3.5.0-GCCcore-11.3.0.eb
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented May 26, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 26, 2023

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=17982 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17982 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10877

Test results coming soon (I hope)...

Details

- notification for comment with ID 1564257476 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 26, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/306e900d2fdfadee99e6d521e0b12258 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented May 26, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 26, 2023

@lexming: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17982 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17982 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2670

Test results coming soon (I hope)...

Details

- notification for comment with ID 1564271073 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 26, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/5a2d12d0c7e698c177838915009b0825 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented May 30, 2023

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/8a2b4f253cf7824ee9bd7b0d0f1c3673 for a full test report.

verdurin
verdurin approved these changes Jun 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin verdurin added this to the next release (4.7.3?) milestone Jun 22, 2023
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jun 22, 2023

Going in, thanks @lexming!

@verdurin verdurin merged commit 3989e1e into easybuilders:develop Jun 22, 2023
@lexming lexming deleted the 20230526120100_new_pr_JupyterLab350 branch June 22, 2023 14:54
@boegel boegel changed the title update JupyterLab v3.5.0 to set JUPYTERLAB_SETTINGS_DIR and JUPYTERLAB_WORKSPACES_DIR on module load update JupyterLab v3.5.0 to set $JUPYTERLAB_SETTINGS_DIR and $JUPYTERLAB_WORKSPACES_DIR on module load Jul 5, 2023
@boegel boegel changed the title update JupyterLab v3.5.0 to set $JUPYTERLAB_SETTINGS_DIR and $JUPYTERLAB_WORKSPACES_DIR on module load update JupyterLab v3.5.0 to set $JUPYTERLAB_SETTINGS_DIR and $JUPYTERLAB_WORKSPACES_DIR on loading of module Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm left review comments

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lexming @verdurin @boegelbot @jfgrimm