Skip to content

enable building static libs and check for libexslt.* in libxslt#18064

Merged
verdurin merged 2 commits intoeasybuilders:developfrom
branfosj:20230609090133_new_pr_libxslt1137
Jun 9, 2023
Merged

enable building static libs and check for libexslt.* in libxslt#18064
verdurin merged 2 commits intoeasybuilders:developfrom
branfosj:20230609090133_new_pr_libxslt1137

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jun 9, 2023 •
edited
Loading

(created using eb --new-pr)

Between libxslt 1.1.34 and 1.1.37 the default changed from building static libs to not building static libs.

@branfosj branfosj changed the title enable building static libs^Cnd check for libexslt.* in libxslt enable building static libs and check for libexslt.* in libxslt Jun 9, 2023
@branfosj branfosj added this to the next release (4.7.3?) milestone Jun 9, 2023
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jun 9, 2023

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/65444af653356c5825c21aca8a8d13b5 for a full test report.

Flamefire
Flamefire reviewed Jun 9, 2023
View reviewed changes
Comment thread easybuild/easyconfigs/l/libxslt/libxslt-1.1.37-GCCcore-12.2.0.eb Outdated
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jun 9, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 9, 2023

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=18064 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18064 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10962

Test results coming soon (I hope)...

Details

- notification for comment with ID 1584190799 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jun 9, 2023

Test report by @verdurin
FAILED
Build succeeded for 2 out of 3 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/a8a137fc9baadf9b71db5083c195a405 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 9, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2d13cbe3cbe3f7fb7edca670b255babc for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jun 9, 2023

Static library check failed:

== postprocessing [skipped]
== sanity checking...
  >> file 'bin/xsltproc' found: OK
  >> file 'include/libxslt/xslt.h' found: OK
  >> file 'lib/libxslt.so' found: OK
  >> file 'lib/libxslt.a' found: FAILED
  >> file 'lib/libexslt.so' found: OK
  >> file 'lib/libexslt.a' found: FAILED
  >> (non-empty) directory 'include/libxslt' found: OK
  >> (non-empty) directory 'include/libexslt' found: OK
  >> loading modules: libxslt/1.1.37-GCCcore-12.2.0...
== ... (took < 1 sec)
== FAILED: Installation ended unsuccessfully (build directory: /dev/shm/libxslt/1.1.37/GCCcore-12.2.0): build failed (first 300 chars): Sanity check failed: no file found at 'lib/libxslt.a' in
/eb/maint/software/libxslt/1.1.37-GCCcore-12.2.0
no file found at 'lib/libexslt.a' in /eb/maint/software/libxslt/1.1.37-GCCcore-12.2.0 (took 3 secs)

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jun 9, 2023

@verdurin Can you check the configure output in the log. For static I see:

checking if gcc static flag -static works... yes
checking whether to build static libraries... yes

Or some other indication of why this is different for you?

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jun 9, 2023

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/b80b62d2808f826bddf963f5f706edda for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jun 9, 2023

@branfosj that was operator error - all fine now.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jun 9, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 9, 2023

@verdurin: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18064 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18064 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2753

Test results coming soon (I hope)...

Details

- notification for comment with ID 1584366363 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 9, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/c1cb8f6e0438b1950a33095585cc200c for a full test report.

verdurin
verdurin approved these changes Jun 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jun 9, 2023

Going in, thanks @branfosj!

@verdurin verdurin merged commit 85b3b1f into easybuilders:develop Jun 9, 2023
@branfosj branfosj deleted the 20230609090133_new_pr_libxslt1137 branch June 9, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

+1 more reviewer

@Flamefire Flamefire Flamefire left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@branfosj @boegelbot @verdurin @Flamefire