Conversation
There was a problem hiding this comment.
Just to be explicit on this, it is not needed because it is fed via the toolchain?
I am concerned that it will be a build dependency and at runtime may bind with any other fftw you may have...
There was a problem hiding this comment.
Yes, this exact dep is in the toolchain.
You can't just load another FFTW, since that would conflict with the one from the toolchain.
The reason I fixed this is because the conflict occured when I replaced goalf-1.1.0 with goolf-1.4.10, which uses FFTW v3.3.3, thus I got a conflict.
|
@fgeorgatos: Please review in full, this fixes all issues with the current set of easyconfigs, i.e. I'm able to build a full dependency graph (which is basically kind of like a unit test for easyconfigs, since it parses them and checks all dependencies): $ eb --dep-graph=all.dot ../easybuild-easyconfigs/easybuild/easyconfigs -ldr
...
== 2013-03-27 09:41:12,331 main INFO Creating dependency graph all.dot
Wrote dependency graph to all.dot |
|
OK, went through the individual changes as commits, otherwise it wasn't possible to do this quickly. "It all looks good, ready to merge in" (famous last words) |
No description provided.