Skip to content

remove incorrect '-Dgallium-drivers=swrast' configure option in ROOT easyconfigs#18260

Merged
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20230704200125_new_pr_ROOT62406
Jul 5, 2023
Merged

remove incorrect '-Dgallium-drivers=swrast' configure option in ROOT easyconfigs#18260
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20230704200125_new_pr_ROOT62406

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jul 4, 2023

(created using eb --new-pr)

@boegel boegel added this to the next release (4.7.3?) milestone Jul 4, 2023
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 4, 2023

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 4, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18260 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18260 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11203

Test results coming soon (I hope)...

Details

- notification for comment with ID 1620592265 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 5, 2023

test build on generoso worked, but test report didn't make it back into the PR due to easybuilders/easybuild-framework#3934

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 5, 2023

@boegelbot please test @ jsc-zen2
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 5, 2023

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18260 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18260 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2951

Test results coming soon (I hope)...

Details

- notification for comment with ID 1621097187 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 5, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (3 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/e39576b02aed62f41ff32a938ac0fa3a for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 5, 2023

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3108.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/7fe8d3da73fb9dacee46d1e113c8511a for a full test report.

Micket
Micket approved these changes Jul 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jul 5, 2023

Going in, thanks @boegel!

@Micket Micket merged commit 3165882 into easybuilders:develop Jul 5, 2023
@boegel boegel deleted the 20230704200125_new_pr_ROOT62406 branch July 5, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @Micket