Skip to content

add missing nbclassic extension to jupyter-server 1.21.0#18389

Merged
verdurin merged 2 commits intoeasybuilders:developfrom
sara-nl:20230725180518_new_pr_jupyter-server1210
Jul 26, 2023
Merged

add missing nbclassic extension to jupyter-server 1.21.0#18389
verdurin merged 2 commits intoeasybuilders:developfrom
sara-nl:20230725180518_new_pr_jupyter-server1210

Conversation

@casparvl
Copy link
Copy Markdown
Contributor

@casparvl casparvl commented Jul 25, 2023 •
edited
Loading

(created using eb --new-pr)

When starting Jupyter Notebook Servers using JupyterHub, if jupyter-server is also present, the traditional notebooks interface requires nbclassic to work. See https://jupyter-server.readthedocs.io/en/latest/operators/migrate-from-nbserver.html#running-jupyter-notebook-on-jupyter-server. If you don't provide it, but have both JupyterHub and jupyter-server, you'll get a 404 (or at least, I did).

This PR solves that. We use nbclassic 0.4.8 and notebook-shim 0.1.0 (the same versions as used in JupyterLab-3.5.0-GCCcore-11.3.0.eb) as to avoid needing hatchling.

@casparvl casparvl changed the title When starting Jupyter Notebook Servers using JupyterHub, if jupyter-server is _also_ present, the traditional notebooks interface requires nbclassic to work. See https://jupyter-server.readthedocs.io/en/latest/operators/migrate-from-nbserver.html#running-jupyter-notebook-on-jupyter-server. {tools}[GCCcore/11.3.0] jupyter-server 1.21.0 Jul 25, 2023
@casparvl
Copy link
Copy Markdown
Contributor Author

casparvl commented Jul 25, 2023

Test report by @casparvl
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
int6 - Linux RHEL 8.6, x86_64, AMD EPYC 7F72 24-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/df97dd3807aa413ae1fecdae2462b63b for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor Author

casparvl commented Jul 25, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 25, 2023

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=18389 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18389 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11293

Test results coming soon (I hope)...

Details

- notification for comment with ID 1650204615 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Copy Markdown
Contributor Author

casparvl commented Jul 25, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 25, 2023

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18389 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18389 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3020

Test results coming soon (I hope)...

Details

- notification for comment with ID 1650206418 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 25, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d1035132b3874878f07a6104f467eec5 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 25, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/c1c758fc83c8550af46519422adb226b for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jul 26, 2023

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/cefb7f976f0a1474b13e44e74b92e2dc for a full test report.

verdurin
verdurin approved these changes Jul 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin verdurin added this to the next release (4.8.1?) milestone Jul 26, 2023
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jul 26, 2023

Going in, thanks @casparvl!

@verdurin verdurin merged commit 93f8fa9 into easybuilders:develop Jul 26, 2023
@casparvl casparvl mentioned this pull request Jul 31, 2023
Merged
@boegel boegel changed the title {tools}[GCCcore/11.3.0] jupyter-server 1.21.0 add missing nbclassic extension to jupyter-server 1.21.0 Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@casparvl @boegelbot @verdurin