Skip to content

fix compiler flags and toolchain options for ScaLAPACK 2.1.0#18397

Merged
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:20230726141918_new_pr_ScaLAPACK210
Aug 1, 2023
Merged

fix compiler flags and toolchain options for ScaLAPACK 2.1.0#18397
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:20230726141918_new_pr_ScaLAPACK210

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jul 26, 2023 •
edited
Loading

(created using eb --new-pr)

The change of

configopts += '-DCMAKE_C_COMPILER=mpicc '
configopts += '-DCMAKE_Fortran_COMPILER=mpif90 '

to

'usempi': True

breaks the detection of MPI.

@branfosj branfosj marked this pull request as draft July 26, 2023 13:40
@branfosj branfosj added this to the next release (4.8.1?) milestone Jul 26, 2023
@branfosj branfosj marked this pull request as ready for review July 26, 2023 13:56
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jul 26, 2023 •
edited
Loading

Test report by @branfosj
FAILED
Build succeeded for 7 out of 8 (7 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/7eeaf4803820f17d8ac64517d5197d8e for a full test report.

edit fails on ScaLAPACK-2.1.0-iimpi-2020b-bf.eb, so I've removed the changes to that ec from this PR

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 31, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 31, 2023

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18397 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18397 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3043

Test results coming soon (I hope)...

Details

- notification for comment with ID 1658986040 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 31, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 11 out of 11 (6 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/748cd3b77c0f4ec623f1537281b9aadb for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 1, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 1, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18397 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18397 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11334

Test results coming soon (I hope)...

Details

- notification for comment with ID 1659765837 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 1, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/107d4de4a9d00c78b2afe4582e5464dc for a full test report.

@boegel boegel changed the title fix flags and options in ScaLAPACK 2.1.0 fix compiler flags and toolchain options for ScaLAPACK 2.1.0 Aug 1, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 1, 2023

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3106.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/d4c0f061e2abc2ad57f74545b42c405b for a full test report.

boegel
boegel approved these changes Aug 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 1, 2023

Going in, thanks @branfosj!

@boegel boegel merged commit e1b49d5 into easybuilders:develop Aug 1, 2023
@branfosj branfosj deleted the 20230726141918_new_pr_ScaLAPACK210 branch August 1, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegel @boegelbot