Skip to content

fix installation of Python bindings for Arrow 0.17.1 by adding --no-build-isolation to pip install command#18440

Merged
casparvl merged 1 commit intoeasybuilders:developfrom
boegel:20230801215522_new_pr_Arrow0171
Aug 2, 2023
Merged

fix installation of Python bindings for Arrow 0.17.1 by adding --no-build-isolation to pip install command#18440
casparvl merged 1 commit intoeasybuilders:developfrom
boegel:20230801215522_new_pr_Arrow0171

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 1, 2023 •
edited
Loading

(created using eb --new-pr)

cfr. #18327 + #18348

@boegel boegel added the bug fix label Aug 1, 2023
@boegel boegel added this to the next release (4.8.1?) milestone Aug 1, 2023
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 1, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 1, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18440 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18440 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11354

Test results coming soon (I hope)...

Details

- notification for comment with ID 1660998626 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel changed the title fix installation of Python bindings for Arrow 0.17.1 by adding --no-build-isolation to pip install command fix installation of Python bindings for Arrow 0.17.1 by adding --no-build-isolation to pip install command Aug 1, 2023
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 1, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6970e8904e0e8ee56e2751fdff785080 for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Aug 2, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 2, 2023

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18440 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18440 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3063

Test results coming soon (I hope)...

Details

- notification for comment with ID 1661743133 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 2, 2023

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 19 (5 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/359b6294ad8e8dd44f140ee1bfde6418 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 2, 2023

@casparvl jsc-zen2 is missing some old toolchains, which explains the failing test report, I don't think it's worth the effort to get those toolchains in place - the test report from generoso is sufficient in this case imho

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Aug 2, 2023

Agreed. Since it's for very old toolchains, I'm also tempted to be a bit more lenient: not that many people will still use those, and if they do, any additions that may work for them are nice to have.

casparvl
casparvl approved these changes Aug 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Aug 2, 2023

Going in, thanks @boegel!

@casparvl casparvl merged commit 6b21f3b into easybuilders:develop Aug 2, 2023
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 2, 2023

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3106.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/f4b4231ee10a2dfef73357a20760b170 for a full test report.

@boegel boegel deleted the 20230801215522_new_pr_Arrow0171 branch August 2, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casparvl casparvl casparvl approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @casparvl