Skip to content

add patch for LIBSVM 3.30 to pass $CFLAGS + $LDFLAGS and run tests#18454

Merged
casparvl merged 1 commit intoeasybuilders:developfrom
ThomasHoffmann77:20230803114929_new_pr_LIBSVM330
Aug 4, 2023
Merged

add patch for LIBSVM 3.30 to pass $CFLAGS + $LDFLAGS and run tests#18454
casparvl merged 1 commit intoeasybuilders:developfrom
ThomasHoffmann77:20230803114929_new_pr_LIBSVM330

Conversation

@ThomasHoffmann77
Copy link
Copy Markdown
Contributor

@ThomasHoffmann77 ThomasHoffmann77 commented Aug 3, 2023

(created using eb --new-pr)

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Aug 3, 2023

@boegelbot please test @ jsc-zen2

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Aug 3, 2023

Test report by @casparvl
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
tcn240.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/ab7b4b1249ad0f21342c5d5ba2362ed1 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 3, 2023

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18454 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18454 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3079

Test results coming soon (I hope)...

Details

- notification for comment with ID 1664150118 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 3, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/94c7cba70911421d90f2bc0bb538c8a4 for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Aug 4, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 4, 2023

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=18454 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18454 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11379

Test results coming soon (I hope)...

Details

- notification for comment with ID 1665491317 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 4, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns8 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c759e38d9f000c12595099214cc521cd for a full test report.

casparvl
casparvl approved these changes Aug 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl added this to the next release (4.8.1?) milestone Aug 4, 2023
@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Aug 4, 2023

Going in, thanks @ThomasHoffmann77!

@casparvl casparvl merged commit 123f63f into easybuilders:develop Aug 4, 2023
@boegel boegel changed the title fix LIBSVM-3.30-GCCcore-11.3.0.eb: pass CFLAGS/LDFLAGS, add test add patch for LIBSVM 3.30 to pass $CFLAGS + $LDFLAGS and add test Aug 6, 2023
@boegel boegel changed the title add patch for LIBSVM 3.30 to pass $CFLAGS + $LDFLAGS and add test add patch for LIBSVM 3.30 to pass $CFLAGS + $LDFLAGS and run tests Aug 6, 2023
@ThomasHoffmann77 ThomasHoffmann77 deleted the 20230803114929_new_pr_LIBSVM330 branch October 19, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casparvl casparvl casparvl approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasHoffmann77 @casparvl @boegelbot