Skip to content

{lib}[foss/2022a] Optax v0.1.7#18610

Merged
akesandgren merged 2 commits intoeasybuilders:developfrom
smoors:20230822115252_new_pr_Optax017
Aug 23, 2023
Merged

{lib}[foss/2022a] Optax v0.1.7#18610
akesandgren merged 2 commits intoeasybuilders:developfrom
smoors:20230822115252_new_pr_Optax017

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Aug 22, 2023

(created using eb --new-pr)

@smoors smoors added the new label Aug 22, 2023
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Aug 22, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 22, 2023

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=18610 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18610 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11526

Test results coming soon (I hope)...

Details

- notification for comment with ID 1688214417 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 22, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/a132b9176a6b746563be099c192d090e for a full test report.

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Aug 22, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 22, 2023

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18610 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18610 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3222

Test results coming soon (I hope)...

Details

- notification for comment with ID 1688236793 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 22, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/c9fa7370b1e3c0819f319f407c8ce604 for a full test report.

@akesandgren akesandgren added this to the 4.x milestone Aug 23, 2023
@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 23, 2023 •
edited
Loading

Both dm-haiku and dm-tree exists as standalone easyconfigs, any particular reason you didn't choose to keep them as such?

There are other things that need dm-tree like tensorflow-probablility, hopefully coming up in a while in tensorflow-compresssion, for instance.

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Aug 23, 2023

no special reason, i just copied this from alphafold.
i'll use separate easyconfigs for them, no problem

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 23, 2023

@boegelbot Please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 23, 2023

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=18610 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18610 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11533

Test results coming soon (I hope)...

Details

- notification for comment with ID 1689805168 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 23, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/0eaaf825128d932faf338aebc8417cd9 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Aug 23, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 23, 2023

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18610 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18610 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3226

Test results coming soon (I hope)...

Details

- notification for comment with ID 1689834092 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 23, 2023

So this is the non-CUDA version apparently, does it have a CUDA version?

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 23, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/7363c3bd7e6c07bd7457c692da6f2707 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Aug 23, 2023

So this is the non-CUDA version apparently, does it have a CUDA version?

optax itself not, but of course the underlying jax library can use cuda.
should be fairly easy to add a cuda version too, but the user doesn't need it (yet), and i don't really have time to test it.

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 23, 2023

Ok, just checking.

akesandgren
akesandgren approved these changes Aug 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 23, 2023

Going in, thanks @smoors!

@akesandgren akesandgren merged commit 4a822b4 into easybuilders:develop Aug 23, 2023
@boegel boegel modified the milestones: 4.x, next release (4.8.1?) Sep 3, 2023
@smoors smoors deleted the 20230822115252_new_pr_Optax017 branch January 15, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

4 participants

@smoors @boegelbot @akesandgren @boegel