Skip to content

{bio}[foss/2022a] EpiSCORE v0.9.5-20220621 w/ R 4.2.1#18618

Merged
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20230822150912_new_pr_EpiSCORE09520220621
Mar 29, 2024
Merged

{bio}[foss/2022a] EpiSCORE v0.9.5-20220621 w/ R 4.2.1#18618
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20230822150912_new_pr_EpiSCORE09520220621

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 22, 2023

(created using eb --new-pr)

@boegel boegel added the new label Aug 22, 2023
@boegel boegel added this to the 4.x milestone Aug 22, 2023
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 22, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 22, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18618 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18618 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11524

Test results coming soon (I hope)...

Details

- notification for comment with ID 1688159207 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 22, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3104.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/0add31f0a64cf174a36fb5d1dcb3d382 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 22, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/7ebb19deda07e31da6af2046288c9207 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 22, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 22, 2023

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18618 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18618 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3224

Test results coming soon (I hope)...

Details

- notification for comment with ID 1688252060 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 22, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/84a00bb40dfbb73bb568ea9d77add44d for a full test report.

akesandgren
akesandgren previously requested changes Aug 23, 2023
View reviewed changes
Comment thread easybuild/easyconfigs/e/EpiSCORE/EpiSCORE-0.9.5-20220621-foss-2022a-R-4.2.1.eb
easyblock = 'RPackage'

name = 'EpiSCORE'
local_commit = '4f7daef'
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren Aug 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is guaranteed to be unique, better to use full commit string.

Copy link
Copy Markdown
Contributor

@Micket Micket Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the short commit in every single easyconfig that uses local_commit, so i don't think we should start enforcing it here on a repo with 12 commits (with 7 characters still gives 78e9 combinations which assuming a repo has a thousand commits would mean a 1 in which even at 7 character is still 78e9 combinations

Micket
Micket approved these changes Mar 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket dismissed akesandgren’s stale review March 29, 2024 22:23

He's wrong :)

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 29, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 29, 2024

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=18618 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_18618 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3883

Test results coming soon (I hope)...

Details

- notification for comment with ID 2027789603 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 29, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/b081b53480090f2689304fe502873735 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 29, 2024

Going in, thanks @boegel!

@Micket Micket merged commit 029b2c1 into easybuilders:develop Mar 29, 2024
@boegel boegel modified the milestones: 4.x, 4.9.1 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

@akesandgren akesandgren akesandgren left review comments

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @boegelbot @Micket @akesandgren