Skip to content

fix configure option to disable wxwidgets for gnuplot 5.4.6#18691

Merged
smoors merged 1 commit intoeasybuilders:developfrom
Micket:20230830172632_new_pr_gnuplot546
Aug 30, 2023
Merged

fix configure option to disable wxwidgets for gnuplot 5.4.6#18691
smoors merged 1 commit intoeasybuilders:developfrom
Micket:20230830172632_new_pr_gnuplot546

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Aug 30, 2023 •
edited
Loading

(created using eb --new-pr)

In my previous PR #18648, i tried using --without-wx but it looks like it's better to use --disable-wxidgets otherwise it still seems to be looking for wx-config. Thanks to #18600

@Micket Micket added the bug fix label Aug 30, 2023
@Micket Micket added this to the next release (4.8.1?) milestone Aug 30, 2023
@Micket Micket requested a review from smoors August 30, 2023 15:28
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Aug 30, 2023

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.7, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/e8c265dcbb6825a049710379457fa3a9 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Aug 30, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 30, 2023

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=18691 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18691 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11588

Test results coming soon (I hope)...

Details

- notification for comment with ID 1699432265 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 30, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/cc7903cadd4f9da707ba117892b5a531 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Aug 30, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 30, 2023

@Micket: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18691 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18691 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3277

Test results coming soon (I hope)...

Details

- notification for comment with ID 1699439121 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 30, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/13859b7735b551194fc6ef7811b0b22b for a full test report.

smoors
smoors approved these changes Aug 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 30, 2023

Going in, thanks @Micket!

@smoors smoors merged commit b32bcbe into easybuilders:develop Aug 30, 2023
@boegel boegel changed the title Fix disabling of wxwidgets for gnuplot fix configure option to disable wxwidgets for gnuplot 5.4.6 Sep 9, 2023
@Micket Micket deleted the 20230830172632_new_pr_gnuplot546 branch October 11, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @boegelbot @smoors