Skip to content

add flextables extension to R v4.2.1 + v4.2.2#18719

Merged
boegel merged 3 commits intoeasybuilders:developfrom
verdurin:20230904202443_new_pr_R421
Sep 7, 2023
Merged

add flextables extension to R v4.2.1 + v4.2.2#18719
boegel merged 3 commits intoeasybuilders:developfrom
verdurin:20230904202443_new_pr_R421

Conversation

@verdurin
Copy link
Copy Markdown
Member

@verdurin verdurin commented Sep 4, 2023

(created using eb --new-pr)

boegel
boegel requested changes Sep 6, 2023
View reviewed changes
Comment thread easybuild/easyconfigs/r/R/R-4.2.2-foss-2022b.eb
exts_list = [
# include packages that are part of the base installation of R,
# both to make sure they are available (via sanity check),
# and to be able to pass the check for required dependencies when installing extensions in parallel
Copy link
Copy Markdown
Member

@boegel boegel Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verdurin Let's retain these comments?

Copy link
Copy Markdown
Member Author

@verdurin verdurin Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored.

Copy link
Copy Markdown
Member Author

@verdurin verdurin Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's the checksum script that stripped them.

Copy link
Copy Markdown
Member

@boegel boegel Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's --inject-checksums, see also easybuilders/easybuild-framework#3269

@boegel boegel added this to the next release (4.8.1?) milestone Sep 6, 2023
@boegel boegel changed the title Add flextables extension to R/4.2.2, R/4.2.1 add flextables extension to R v4.2.1 + v4.2.2 Sep 7, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 7, 2023

@boegelbot please test @ generoso
EB_ARGS="--skip"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 7, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18719 EB_ARGS="--skip" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18719 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11665

Test results coming soon (I hope)...

Details

- notification for comment with ID 1710392763 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 7, 2023

@boegelbot please test @ jsc-zen2
EB_ARGS="--skip"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 7, 2023

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18719 EB_ARGS="--skip" /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18719 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3327

Test results coming soon (I hope)...

Details

- notification for comment with ID 1710406384 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 7, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/af26a2aa11e340a93d74ad918e7cc5f4 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 7, 2023

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3109.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/f75e306b281d128649f04afa68f754f3 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 7, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/0f871347185f368703f11e19765bc26a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 7, 2023

Going in, thanks @verdurin!

@boegel boegel merged commit 7ef8c98 into easybuilders:develop Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@verdurin @boegel @boegelbot