Skip to content

strip out hardcoded -march=native used by RapidJSON 1.1.0#18725

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:20230906095020_new_pr_RapidJSON110
Sep 6, 2023
Merged

strip out hardcoded -march=native used by RapidJSON 1.1.0#18725
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:20230906095020_new_pr_RapidJSON110

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 6, 2023 •
edited
Loading

(created using eb --new-pr)

This is important when EasyBuild is configuted with --optarch=GENERIC, to avoid this from being used:

-march=x86-64 -mtune=generic -fno-math-errno -march=native

On aarch64, this fixes an actual build failure because GCC fails when combining -mcpu=generic with -march=native:

cc1plus: error: switch -mcpu=generic conflicts with -march=armv8.2-a+crypto+fp16+rcpc+dotprod+ssbs switch [-Werror

@boegel boegel mentioned this pull request Sep 6, 2023
Merged
@boegel boegel added the bug fix label Sep 6, 2023
@boegel boegel added this to the next release (4.8.1?) milestone Sep 6, 2023
@boegel boegel added the EESSI Related to EESSI project label Sep 6, 2023
@boegel boegel changed the title strip out hardcoded -march=native used by RapidJSON 1.1.0 strip out hardcoded -march=native used by RapidJSON 1.1.0 Sep 6, 2023
@boegel boegel force-pushed the 20230906095020_new_pr_RapidJSON110 branch from 130c895 to 4282f2f Compare September 6, 2023 08:00
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 6, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 6, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18725 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18725 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11650

Test results coming soon (I hope)...

Details

- notification for comment with ID 1707859629 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 6, 2023

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
fair-mastodon-c7g-2xlarge-0001 - Linux Rocky Linux 8.7, AArch64, ARM UNKNOWN (neoverse_n1), Python 3.6.8
See https://gist.github.com/boegel/490cec10f3cfec186b0a2fa0cb2f8d10 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 6, 2023

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
node3116.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/24df7838ebe93fe1867ff9b8bdad6a23 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 6, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/b3db133e8c23198ca04d6ce0b59da317 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 6, 2023

@boegelbot please test @ generoso
EB_ARGS="--optarch=GENERIC --installpath /tmp/$USER/pr18725_generic"

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 6, 2023 •
edited
Loading

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
fair-mastodon-c7g-2xlarge-0001 - Linux Rocky Linux 8.7, AArch64, ARM UNKNOWN (neoverse_n1), Python 3.6.8
See https://gist.github.com/boegel/1d9ece486247c1fa3d859bff871e27dc for a full test report.

edit: this was using --optarch=GENERIC

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 6, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18725 EB_ARGS="--optarch=GENERIC --installpath /tmp/$USER/pr18725_generic" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18725 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11651

Test results coming soon (I hope)...

Details

- notification for comment with ID 1707874987 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 6, 2023 •
edited by boegel
Loading

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/ef95f95f6a35c1888e80c0b11f50696c for a full test report.

edit: this was using --optarch=GENERIC

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 6, 2023 •
edited
Loading

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 6, 2023

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18725 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18725 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3320

Test results coming soon (I hope)...

Details

- notification for comment with ID 1707906341 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 6, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/016e11e4bab7a136f7fbf4471b8eeb96 for a full test report.

verdurin
verdurin approved these changes Sep 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Sep 6, 2023

Going in, thanks @boegel!

@verdurin verdurin merged commit a82280d into easybuilders:develop Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

4.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @verdurin