Skip to content

statically link Boost 1.75 in Cufflinks v20190706 installed with GCC/11.2.0, so Boost can be changed to build dependency#18843

Merged
boegel merged 3 commits intoeasybuilders:developfrom
ItIsI-Orient:20230920160913_new_pr_Cufflinks20190706
Sep 21, 2023
Merged

statically link Boost 1.75 in Cufflinks v20190706 installed with GCC/11.2.0, so Boost can be changed to build dependency#18843
boegel merged 3 commits intoeasybuilders:developfrom
ItIsI-Orient:20230920160913_new_pr_Cufflinks20190706

Conversation

@ItIsI-Orient
Copy link
Copy Markdown
Contributor

@ItIsI-Orient ItIsI-Orient commented Sep 20, 2023 •
edited
Loading

This version of Cufflinks easyconfig statically links Boost libraries, so it can be used with packages that require more recent Boost versions.
(for example see #16356)

@ItIsI-Orient ItIsI-Orient changed the title Made Boost get statically linked Cufflinks update: Static linking of Boost libraries Sep 20, 2023
@ItIsI-Orient ItIsI-Orient mentioned this pull request Sep 20, 2023
Merged
@boegel boegel changed the title Cufflinks update: Static linking of Boost libraries statically link Boost 1.75 in Cufflinks v20190706 installed with GCC/11.2.0, so Boost can be changed to build dependency Sep 20, 2023
@boegel boegel added the bug fix label Sep 20, 2023
@boegel boegel added this to the next release (4.8.2?) milestone Sep 20, 2023
boegel
boegel approved these changes Sep 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 20, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=18843 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18843 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11765

Test results coming soon (I hope)...

Details

- notification for comment with ID 1728123098 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3141.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/bb70e440e60477c31b2f43fa97ca383b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 20, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/fdf5b978de994590ae81cc04d059f0b2 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 21, 2023

Going in, thanks @ItIsI-Orient!

@boegel boegel merged commit 1da5f41 into easybuilders:develop Sep 21, 2023
@boegel boegel added the change label Sep 27, 2023
@boegel boegel mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.8.2

Development

Successfully merging this pull request may close these issues.

3 participants

@ItIsI-Orient @boegel @boegelbot