Skip to content

remove 'cstd': 'c++17' as this is default in GCC 11 for Mash#18941

Merged
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20231007103806_new_pr_Mash23
Oct 7, 2023
Merged

remove 'cstd': 'c++17' as this is default in GCC 11 for Mash#18941
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20231007103806_new_pr_Mash23

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Oct 7, 2023 •
edited
Loading

(created using eb --new-pr)

From https://gcc.gnu.org/projects/cxx-status.html#cxx17

C++17 mode is the default since GCC 11

@branfosj branfosj added this to the next release (4.8.2?) milestone Oct 7, 2023
@branfosj branfosj changed the title remove 'cstd': 'c++17' as this is default in GCC 11 remove 'cstd': 'c++17' as this is default in GCC 11 Oct 7, 2023
@branfosj branfosj mentioned this pull request Oct 7, 2023
Merged
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 7, 2023

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/branfosj/88934ac98c111adf114b291386a18d14 for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 7, 2023

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/40ad54bd05ff65c87d2a898591f223ff for a full test report.

@branfosj branfosj changed the title remove 'cstd': 'c++17' as this is default in GCC 11 remove 'cstd': 'c++17' as this is default in GCC 11 for Mash Oct 7, 2023
@easybuilders easybuilders deleted a comment from boegelbot Oct 7, 2023
@easybuilders easybuilders deleted a comment from boegelbot Oct 7, 2023
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 7, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 7, 2023

@branfosj: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18941 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18941 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3501

Test results coming soon (I hope)...

Details

- notification for comment with ID 1751671043 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 7, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/63d846876d7b7e154d83f18341221fa9 for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 7, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 7, 2023

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=18941 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18941 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11886

Test results coming soon (I hope)...

Details

- notification for comment with ID 1751673621 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 7, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e6cfdc4eee026c5ff6efb55ef6f9bfe9 for a full test report.

boegel
boegel approved these changes Oct 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 7, 2023

Going in, thanks @branfosj!

@boegel boegel merged commit c9855ee into easybuilders:develop Oct 7, 2023
@branfosj branfosj deleted the 20231007103806_new_pr_Mash23 branch October 7, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

4.8.2

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegelbot @boegel