Skip to content

remove 'cstd': 'c++17' as this is default in GCC 11 for GATE#18945

Closed
branfosj wants to merge 1 commit intoeasybuilders:developfrom
branfosj:20231007111909_new_pr_GATE91
Closed

remove 'cstd': 'c++17' as this is default in GCC 11 for GATE#18945
branfosj wants to merge 1 commit intoeasybuilders:developfrom
branfosj:20231007111909_new_pr_GATE91

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Oct 7, 2023 •
edited
Loading

(created using eb --new-pr)

From https://gcc.gnu.org/projects/cxx-status.html#cxx17

C++17 mode is the default since GCC 11

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 7, 2023

@boegelbot please test @ generoso

@branfosj branfosj added this to the next release (4.8.2?) milestone Oct 7, 2023
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 7, 2023

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=18945 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18945 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11888

Test results coming soon (I hope)...

Details

- notification for comment with ID 1751674242 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 7, 2023

@boegelbot please test @ jsc-zen2

@branfosj branfosj changed the title remove 'cstd': 'c++17' as this is default in GCC 11 for GATE remove 'cstd': 'c++17' as this is default in GCC 11 for GATE Oct 7, 2023
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 7, 2023

@branfosj: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18945 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18945 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3505

Test results coming soon (I hope)...

Details

- notification for comment with ID 1751675581 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 7, 2023

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/68f22054c367d6582dad49a781151a5c for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 7, 2023

Test report by @branfosj
FAILED
Build succeeded for 5 out of 6 (1 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/25bf7a914424d40ad9b3a38bd9135ceb for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Oct 7, 2023

The error error: string_view is not a member of std is consistent with using an earlier CXX standard. Some part of GATE is causing -std=c++11 to appear in the build. So closing this PR.

@branfosj branfosj closed this Oct 7, 2023
@branfosj branfosj deleted the 20231007111909_new_pr_GATE91 branch October 7, 2023 10:56
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 7, 2023

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f4e0e047bd46d6b57c29f1332caac4f0 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

4.8.2

Development

Successfully merging this pull request may close these issues.

2 participants

@branfosj @boegelbot