Skip to content

{bio}[foss/2022a] starparser-1.49-foss-2022a.eb#18965

Merged
smoors merged 2 commits intoeasybuilders:developfrom
ThomasHoffmann77:20231010123850_new_pr_starparser149
Oct 18, 2023
Merged

{bio}[foss/2022a] starparser-1.49-foss-2022a.eb#18965
smoors merged 2 commits intoeasybuilders:developfrom
ThomasHoffmann77:20231010123850_new_pr_starparser149

Conversation

@ThomasHoffmann77
Copy link
Copy Markdown
Contributor

@ThomasHoffmann77 ThomasHoffmann77 commented Oct 10, 2023

(created using eb --new-pr)

@smoors smoors added 2018b new and removed 2018b labels Oct 13, 2023
smoors
smoors reviewed Oct 13, 2023
View reviewed changes
Comment thread easybuild/easyconfigs/s/starparser/starparser-1.49-foss-2022a.eb Outdated
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 18, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 18, 2023

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=18965 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18965 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11956

Test results coming soon (I hope)...

Details

- notification for comment with ID 1768045830 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 18, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/263f024669c2f03eaab699f9e6f702c3 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 18, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 18, 2023

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18965 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18965 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3572

Test results coming soon (I hope)...

Details

- notification for comment with ID 1768086989 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 18, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/0b98337eda4a5d65a51d5f1f6d26636c for a full test report.

@smoors smoors added this to the next release (4.8.2?) milestone Oct 18, 2023
smoors
smoors approved these changes Oct 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 18, 2023

Going in, thanks @ThomasHoffmann77!

@smoors smoors merged commit 00e7406 into easybuilders:develop Oct 18, 2023
@ThomasHoffmann77 ThomasHoffmann77 deleted the 20231010123850_new_pr_starparser149 branch October 19, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.8.2

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasHoffmann77 @smoors @boegelbot