Skip to content

rename CVS to ConcurrentVersionsSystem#18985

Merged
boegel merged 5 commits intoeasybuilders:developfrom
Micket:cvs_rename
Oct 26, 2023
Merged

rename CVS to ConcurrentVersionsSystem#18985
boegel merged 5 commits intoeasybuilders:developfrom
Micket:cvs_rename

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Oct 11, 2023

Due to Python not liking directories named CVS.

I thought we had an issue open on this somewhere but couldn't find it. Mentioned in the notes: https://github.com/easybuilders/easybuild/wiki/Conference-call-notes-20231011

@Micket Micket added the bug fix label Oct 11, 2023
@Micket Micket added this to the next release (4.8.2?) milestone Oct 11, 2023
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 21, 2023

Test report by @Micket
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.8, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/0b32a751fda13df17f139be38f149842 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 21, 2023

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.8, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/ca62abc83704b8295ef33a7cb5bbef7d for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 21, 2023 •
edited
Loading

@boegelbot please test @ generoso
EB_ARGS="ConcurrentVersionsSystem-1.11.23-GCCcore-11.2.0.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 21, 2023

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=18985 EB_ARGS="ConcurrentVersionsSystem-1.11.23-GCCcore-11.2.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18985 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11988

Test results coming soon (I hope)...

Details

- notification for comment with ID 1773824367 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 21, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d27a1eff6fc2b60dfb85b5ec1f438f0b for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 21, 2023

@boegelbot please test @ jsc-zen2
EB_ARGS="ConcurrentVersionsSystem-1.11.23-GCCcore-11.2.0.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 21, 2023

@Micket: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18985 EB_ARGS="ConcurrentVersionsSystem-1.11.23-GCCcore-11.2.0.eb" EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18985 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3592

Test results coming soon (I hope)...

Details

- notification for comment with ID 1773834559 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 21, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/10591764b427765fd1674575a2301666 for a full test report.

@boegel boegel added the change label Oct 25, 2023
@boegel boegel mentioned this pull request Oct 25, 2023
Merged
boegel
boegel approved these changes Oct 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 26, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/78963205242864a3fa20d10aa3354f4e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 26, 2023

Going in, thanks @Micket!

@boegel boegel merged commit 445750e into easybuilders:develop Oct 26, 2023
@boegel boegel changed the title Rename CVS to ConcurrentVersionsSystem rename CVS to ConcurrentVersionsSystem Nov 7, 2023
@Micket Micket deleted the cvs_rename branch April 7, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.8.2

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @boegelbot @boegel