Skip to content

{tools}[system/system] Jmol v16.1.41#18988

Merged
smoors merged 5 commits intoeasybuilders:developfrom
jonroddom:20231011151640_new_pr_Jmol16141
Oct 12, 2023
Merged

{tools}[system/system] Jmol v16.1.41#18988
smoors merged 5 commits intoeasybuilders:developfrom
jonroddom:20231011151640_new_pr_Jmol16141

Conversation

@jonroddom
Copy link
Copy Markdown

(created using eb --new-pr)

@smoors smoors added the new label Oct 11, 2023
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 11, 2023

@jonroddom thanks a lot for your contribution!

Jmol needs Java to work, so you should add a Java dependency:

dependencies = [('Java', '11')]

and also add a versionsuffix:

versionsuffix = '-Java-%(javaver)s'

@jonroddom
Copy link
Copy Markdown
Author

Hi Sam,

Thanks for the feedback. I'm still learning the ropes! Changes made accordingly.

Cheers,

Jon

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 12, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=18988 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18988 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11927

Test results coming soon (I hope)...

Details

- notification for comment with ID 1759891593 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/34e80a635df1352fea36ecff4aa98f53 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 12, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18988 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18988 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3542

Test results coming soon (I hope)...

Details

- notification for comment with ID 1759934313 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/df4a508e84815f59ed57b2769f5c80c8 for a full test report.

@smoors smoors added this to the next release (4.8.2?) milestone Oct 12, 2023
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Oct 12, 2023

Going in, thanks @jonroddom!

@smoors smoors merged commit d826bc4 into easybuilders:develop Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants