{astro,lib}[foss/2022a] DP3-6.0, WSClean 3.3-b6b995c7 and deps by t1mk1k · Pull Request #19010 · easybuilders/easybuild-easyconfigs

t1mk1k · 2023-10-12T15:03:15Z

Software for the calibration (DP3) and imaging (WSClean) of radio astronomy data and their dependencies.

boegel · 2023-10-17T09:27:36Z

@boegelbot please test @ generoso

boegelbot · 2023-10-17T09:30:05Z

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19010 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19010 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 11944

Test results coming soon (I hope)...

Details

- notification for comment with ID 1766028329 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-10-17T09:38:54Z

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 8 (8 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c9f0849fab9951d7410744782b0fc31a for a full test report.

casparvl

Hi @t1mk1k , welcome to EasyBuild, and: very nice first PR!

I've made a number of suggestions: nothing that is downright wrong or broken, but largely things that as a community we've build experience on and nowadays do in a certain way (and usually for good reason :)).

Let me know if you have questions or comments about any of it!

…asacore

casparvl · 2023-10-19T14:38:35Z

@boegelbot please test @ generoso

boegelbot · 2023-10-19T14:40:04Z

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19010 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19010 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 11967

Test results coming soon (I hope)...

Details

- notification for comment with ID 1771127936 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

casparvl · 2023-10-19T14:41:03Z

@boegelbot please test @ jsc-zen2

boegelbot · 2023-10-19T14:43:52Z

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/3e68e69278124da4ab5ab1b64d497db4 for a full test report.

casparvl · 2023-10-19T15:17:44Z

@boegelbot please test @ generoso

boegelbot · 2023-10-19T15:20:05Z

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19010 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19010 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 11968

Test results coming soon (I hope)...

Details

- notification for comment with ID 1771203120 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-10-19T16:02:45Z

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e393121902898f21bfbae60a94529ad0 for a full test report.

casparvl · 2023-10-19T16:05:27Z

Test report by @casparvl
SUCCESS
Build succeeded for 8 out of 8 (7 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/924b486b3c208bd1f8a4538622f8754d for a full test report.

casparvl · 2023-10-19T16:07:08Z

@t1mk1k I see that our jsc-zen2 test system is down today. I'll schedule a test there tomorrow, but the fact that everything passes on our generoso test cluster and on Snellius makes me not expect any issues with jsc-zen2.

t1mk1k · 2023-10-19T16:33:28Z

Sounds good @casparvl. Thanks for your help!

casparvl · 2023-10-20T07:14:03Z

@boegelbot please test @ jsc-zen2

boegelbot · 2023-10-20T07:15:06Z

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19010 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19010 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 3587

Test results coming soon (I hope)...

Details

- notification for comment with ID 1772206833 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-10-20T07:26:35Z

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 7 (7 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/092188cd845d3d6d23631d1b59f517bf for a full test report.

casparvl · 2023-10-20T07:51:43Z

@boegelbot please test @ jsc-zen2

boegelbot · 2023-10-20T07:55:12Z

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19010 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19010 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 3588

Test results coming soon (I hope)...

Details

- notification for comment with ID 1772254146 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-10-20T08:08:00Z

Test report by @boegelbot
FAILED
Build succeeded for 4 out of 7 (7 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/32f32b6d39616cfdfea3946e6333f903 for a full test report.

casparvl · 2023-10-20T09:12:41Z

As discussed on chat: it's not 100% clear if wget is a build time or runtime dependency for EveryBeam, but we think it is build time only. It seems to be called only by scripts like these , which seem to be called as part of a build target here. The scripts do not seem to be installed.

Just to note for future reference: this does mean that the installation needs to happen on an online system.

casparvl · 2023-10-20T09:13:19Z

@boegelbot please test @ jsc-zen2

boegelbot · 2023-10-20T09:15:05Z

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19010 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19010 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 3589

Test results coming soon (I hope)...

Details

- notification for comment with ID 1772369589 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-10-20T09:33:54Z

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/692f0b7dc8b479e9e17c5ea3d467797a for a full test report.

casparvl · 2023-10-20T13:26:13Z

@boegelbot please test @ generoso

casparvl

EasyConfigs look good to me. Final tests on generoso and Snellius after the latest commits, though these shouldn't give issues. Once these complete, this is ready to merge.

boegelbot · 2023-10-20T13:30:05Z

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19010 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19010 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 11986

Test results coming soon (I hope)...

Details

- notification for comment with ID 1772738896 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

casparvl · 2023-10-20T14:08:30Z

Test report by @casparvl
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/c500fce2e3924c2f4ab82fa190b80947 for a full test report.

boegelbot · 2023-10-20T14:13:21Z

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/38216b7547f8c3f72908f855d920dfd3 for a full test report.

{astro,lib}[foss/2022a] DP3-6.0, WSClean 3.3-b6b995c7 and deps

145cf18

boegel added new update labels Oct 13, 2023

boegel added this to the 4.x milestone Oct 13, 2023

Tim Kok added 5 commits October 13, 2023 09:52

Fix linting errors

1a478fb

Fix dependencies and checksums

48c09cd

Switch to HDF5 1.14.0 + add sanity_check_paths

17cee71

Use official release of WSClean

096f9eb

Revert deleted lines

74210b0

easybuilders deleted a comment from boegelbot Oct 17, 2023

Tim Kok added 2 commits October 17, 2023 12:18

Add Boost to casacore dependencies

f056a47

Remove binutils from configs using foss-2022a toolchain

94fd7da

casparvl requested changes Oct 17, 2023

View reviewed changes

Add sanity check commands + switch to parallel HDF5 + add Python to c…

65ce5fa

…asacore

t1mk1k requested a review from casparvl October 18, 2023 16:49

Add GSL dependency to casacore

d9de7ea

Add wget to casacore as a builddependency

2b200ac

Tim Kok added 2 commits October 20, 2023 10:26

Add wget to casacore as a regular dependency

ad74128

Add wget to casacore and EveryBeam as a build dependency

edbef0f

casparvl approved these changes Oct 20, 2023

View reviewed changes

casparvl merged commit 2fb8f0a into easybuilders:develop Oct 20, 2023

smoors modified the milestones: 4.x, next release (4.8.2?) Oct 21, 2023

boegel mentioned this pull request Nov 8, 2023

{lib}[foss/2021b] WSClean v3.1 #15505

Closed

4 tasks

Conversation

t1mk1k commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boegel commented Oct 17, 2023

Uh oh!

boegelbot commented Oct 17, 2023

Uh oh!

boegelbot commented Oct 17, 2023

Uh oh!

casparvl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

casparvl commented Oct 19, 2023

Uh oh!

boegelbot commented Oct 19, 2023

Uh oh!

casparvl commented Oct 19, 2023

Uh oh!

boegelbot commented Oct 19, 2023

Uh oh!

casparvl commented Oct 19, 2023

Uh oh!

boegelbot commented Oct 19, 2023

Uh oh!

boegelbot commented Oct 19, 2023

Uh oh!

casparvl commented Oct 19, 2023

Uh oh!

casparvl commented Oct 19, 2023

Uh oh!

t1mk1k commented Oct 19, 2023

Uh oh!

casparvl commented Oct 20, 2023

Uh oh!

boegelbot commented Oct 20, 2023

Uh oh!

boegelbot commented Oct 20, 2023

Uh oh!

casparvl commented Oct 20, 2023

Uh oh!

boegelbot commented Oct 20, 2023

Uh oh!

boegelbot commented Oct 20, 2023

Uh oh!

casparvl commented Oct 20, 2023

Uh oh!

casparvl commented Oct 20, 2023

Uh oh!

boegelbot commented Oct 20, 2023

Uh oh!

boegelbot commented Oct 20, 2023

Uh oh!

casparvl commented Oct 20, 2023

Uh oh!

casparvl left a comment

Choose a reason for hiding this comment

Uh oh!

boegelbot commented Oct 20, 2023

Uh oh!

casparvl commented Oct 20, 2023

Uh oh!

boegelbot commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

t1mk1k commented Oct 12, 2023 •

edited

Loading