{lib}[foss/2022a] zeus-mcmc v2.5.4#19033
{lib}[foss/2022a] zeus-mcmc v2.5.4#19033migueldiascosta merged 4 commits intoeasybuilders:developfrom
Conversation
|
Test report by @jose-d |
|
Test report by @jose-d |
| }), | ||
| ] | ||
|
|
||
| moduleclass = 'lib' |
There was a problem hiding this comment.
well, lib is arguably better than emcees astro, but since this is the first easyconfig for zeus-mcmc, how do you feel about changing this to math?
There was a problem hiding this comment.
Both libraries (emcee and zeus-mcmc) are maintained by people with astro background - see authors profiles at github:
- zeus-mcmc: https://github.com/minaskar
- emcee: https://github.com/dfm
At our facilities, we use the libs in research related to astro-physics or cosmology, anyway, use out-of this field is not forbidden indeed :)
That's why I went with very generic lib(not as I did few years ago with emcee ) ...
I'd follow your suggestion as you have better overview how moduleclass is used in broader context here..
All math,lib, and even astro seems to be okayish to me..
So I'm not strongly opinionated. 🤔
There was a problem hiding this comment.
both packages look completely generic MCMC implementations to me, I don't see anything domain specific about them
but indeed moduleclass is often subjective and nothing is enforced at all, so definitely not a hill worth dying on :)
There was a problem hiding this comment.
change lib → math done. ✅
|
@boegelbot please test @ generoso |
|
@migueldiascosta: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 1770335406 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
(zeus-)MCMC is statistical sampling method, so use of moduleclass `math` seems to be more descriptive than generic `lib`
|
Going in, thanks @jose-d! |
(created using
eb --new-pr)