Skip to content

add missing GSL dependency for casacore 3.4.0#19042

Merged
Micket merged 1 commit intoeasybuilders:developfrom
t1mk1k:20231019172300_new_pr_casacore340
Oct 20, 2023
Merged

add missing GSL dependency for casacore 3.4.0#19042
Micket merged 1 commit intoeasybuilders:developfrom
t1mk1k:20231019172300_new_pr_casacore340

Conversation

@t1mk1k
Copy link
Copy Markdown

@t1mk1k t1mk1k commented Oct 19, 2023

Running tests for casacore 3.5.0, we discovered that GSL was missing as a dependency for casacore 3.4.0

The test report:
https://gist.github.com/boegelbot/3e68e69278124da4ab5ab1b64d497db4

@Micket Micket added the bug fix label Oct 19, 2023
@Micket Micket added this to the next release (4.8.2?) milestone Oct 19, 2023
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 19, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 19, 2023

@Micket: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19042 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19042 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3585

Test results coming soon (I hope)...

Details

- notification for comment with ID 1771818187 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 19, 2023

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.8, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/4c8b0f34942bb2b17ff243cd5f642f56 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 19, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/2eab62fdd176ef1050c3e18cc8ef720b for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 19, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 19, 2023

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=19042 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19042 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11983

Test results coming soon (I hope)...

Details

- notification for comment with ID 1771830188 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 19, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/0388a20e49ee75a8aa9d81608a325e89 for a full test report.

Micket
Micket approved these changes Oct 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit af66832 into easybuilders:develop Oct 20, 2023
@boegel boegel changed the title Adding missing GSL dependency to casacore-3.4.0-foss-2021b add missing GSL dependency for casacore 3.4.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.8.2

Development

Successfully merging this pull request may close these issues.

3 participants

@t1mk1k @Micket @boegelbot